Skip to content

path sweep bug fix for closed=true, speed improvement in rounded_prism() #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianVmariano merged 2 commits into from
Aug 21, 2025
Merged

path sweep bug fix for closed=true, speed improvement in rounded_prism() #1779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e16e1
Fix bug which creates internal faces in path_sweep when closed=true
adrianVmariano Aug 20, 2025
7ec33d6
remove triangulation from top/bottom of rounded_prism because it
adrianVmariano Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rounding.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2572,8 +2572,9 @@ function rounded_prism(bottom, top, joint_bot=0, joint_top=0, joint_sides=0, k_b
vnf = vnf_join([ each column(top_samples,0),
each column(bot_samples,0),
for(pts=edge_points) vnf_vertex_array(pts),
debug ? vnf_from_polygons(faces,fast=true)
: vnf_triangulate(vnf_from_polygons(faces))
vnf_from_polygons(faces,fast=true)
// debug ? vnf_from_polygons(faces,fast=true)
// : vnf_triangulate(vnf_from_polygons(faces))
]),

topnormal = unit(cross(top[0]-top[1],top[2]-top[1])),
Expand Down
3 changes: 3 additions & 0 deletions skin.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2276,6 +2276,9 @@ function path_sweep(shape, path, method="incremental", normal, closed, twist=0,
assert(!closed || !approx(path[0],last(path)), "\nClosed path includes start point at the end.")
assert((is_region(shape) || is_path(shape,2)) || (transforms && !(closed && method=="incremental")),"\nshape must be a 2d path or region.")
let(
caps = !closed ? caps
: assert(is_undef(caps) || caps==false || caps==[false,false], "Cannot specify caps when closed=true")
false,
path = path3d(path),
normalOK = is_undef(normal) || (method!="natural" && is_vector(normal,3))
|| (method=="manual" && same_shape(normal,path)),
Expand Down