Correct emission/fee/burn accumulation by migrating from int64_t to unsigned long long in get_coinbase_tx_sum #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wallet was crashing if you passed in an integer ID in the JSON RPC command because it was only expecting to read a string for it. This meant returning the try-catch into epee's serialisation for `get_value()` which on paper, looks and should be a non-exception throwing function on failure as it returns a boolean and there's only one reasonable way for it to fail, that the key doesn't coerce to the requested type. Fix a null ID being assigned to the JSON response on error by setting the ID in the error.
The previous implementation used int64_t values in std::tuple<int64_t,int64_t,int64_t>, which overflow once chain totals exceed the signed 64-bit range, causing negative emission values. Emission, fees, and burnt amounts are non-negative monetary quantities and should be stored as unsigned long long.
sanada08
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.