Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the way we handle custom environment-based building blocks. Previously, we used two separate traits —
ToEncodeandEnvironmentEncode— to manage encoding logic. This approach has now been streamlined.What's Changed
Instead of relying on custom encoding traits, we now focus on converting environment variables directly into
ManifestValue. These values are then passed normally to themanifest_args!()macro, eliminating the need for additional encoding logic and simplifying the interface.To support this, the new
ToValuetrait has been introduced:Benefits
Example: Handling Optional Environment Variables
We’ve introduced an
EnvOptionenum to model optional environment values, along with itsToValueimplementation:Additional Improvements
We also added dedicated environment types for the four supported address kinds:
EnvResourceEnvAccountEnvComponentEnvPackageThis makes it easier to implement custom types and simplifies manifest parameter construction.
Example: Custom Tuple Type
Here’s how we define a custom type representing a
(ComponentAddress, FungibleBucket)tuple:Let me know if you'd like a shorter version for internal use or one tailored for external contributors!