Merged
Conversation
Remove OnLand and OnFootstep animation events from 3rdpersondemo FBX imports. These events have no receiver on the LoadingAvatar prefab, causing error spam in play mode. The actual landing/footstep logic uses C# events in BasisLocalAnimatorDriver, not animation events.
Add libonnxruntime.dylib (v1.22.0) for both osx-arm64 and osx-x64, enabling OpenLipSync on macOS. Previously only Windows was supported, causing initialization failures on Mac. Also update managed DLL meta to include OSXUniversal standalone platform.
Previously, HandleBundleAndMetaLoading swallowed exceptions from AssetBundle creation, leaving wrapper.AssetBundle null with no indication of why. This caused a generic "Unable to load" error that gave no actionable information when connecting to a remote server from an unsupported platform (e.g. macOS). Re-throw the caught exception so the actual failure reason (such as missing platform bundle or CRC mismatch) propagates to callers. Improve error messages to include the remote URL and current platform so users can identify the root cause.
dooly123
requested changes
Apr 8, 2026
| if (output.Item1 == null || output.Item3 != string.Empty) | ||
| { | ||
| throw new Exception($"missing Bundle Bytes Array Error Message {output.Item3}"); | ||
| throw new Exception($"Bundle load failed for {wrapper.LoadableBundle.BasisRemoteBundleEncrypted.RemoteBeeFileLocation}: {output.Item3}"); |
Collaborator
There was a problem hiding this comment.
might just want todo a some null checks here for the wrapper parts, dont want to have a exception warning cause a exception
Use null-conditional operators when accessing the wrapper chain in the exception message to prevent a NullReferenceException from being thrown while building the error string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various mac fixes