Add patcher to disable specific mixins in Hodgepodge #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The build failure is due to the fact that I'm running the action on a work laptop which doesn't have access to some of these sites (:ayo:). Looks good to me though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reflection patcher that disables specified mixins in Hodgepodge if Spool is loaded.
I also bumped Hodgepodge & GTNHLib, and set Hodgepodge to run at runtime. I would suggest we keep this active to track future compat.
Looking at GTNewHorizons/Hodgepodge@master...BallOfEnergy1:Hodgepodge:master I see that you also set the simulation distance fields to protected from private - If we have simulation distance in the future, and need to access these Fields, I would recommend that we use a Mixins Accessor instead. Until then, since simulation distance compat is broken anyways, it shouldn't matter.