(WIP) Feature/offset in generator name #67
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format: TerraPlusMinus:yoffset
LM-Wolfert
changed the title
…enerator-name # Conflicts: # src/main/java/de/btegermany/terraplusminus/commands/TpllCommand.java
Contributor
|
Paper documentation on generator extra-parameters (says very little): bukkit.yml. Imo this needs to be carefully considered so make sure it can be expanded upon. We could also consider deprecating world-generation specific settings in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow the y-offset of worlds to be set externally I have added the possibility to add it to the generator name. The format is still up for question, currently it is just the integer offset value (it may be more practical to use a key-value pair to leave room for expansion in the future).
Additionally, the linked worlds configuration usage has been altered to support a 'CUSTOM' linked worlds format, this format does not do anything functionally in this plugin but the idea is that another plugin could implement linked worlds while not having a y-level limitation in this plugin when it is set to CUSTOM.