refac: Add support for the cost breakdown per org unit (SNT-225)#188
Merged
refac: Add support for the cost breakdown per org unit (SNT-225)#188
Conversation
bramj
changed the title
Bewi
approved these changes
Feb 16, 2026
Contributor
Bewi
left a comment
Bewi
left a comment
There was a problem hiding this comment.
LGTM, we could just move the mergeByKey to a utils.
| }; | ||
|
|
||
| /** Group items by key, merging duplicates by summing via `merge`. */ | ||
| function mergeByKey<T>( |
Contributor
There was a problem hiding this comment.
We could move this to a share util function, so we can re-use in other places
Collaborator
Author
There was a problem hiding this comment.
Sorry hit merge too quickly there. But I think we can extract that when it becomes necessary, for now it's specific to this component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
get_places_costs()output (SNT-225) snt-malaria-budgeting#38)BudgetingcomponentNotes
This will be needed to be able to render the "Cost per intervention category" when filtering on a province/region/etc (SNT-225)
Related JIRA: https://bluesquare.atlassian.net/browse/SNT-225
How to test
Not really any visual changes here, so testing would be just to make sure nothing broke.
But to lower complexity on the main PR, I decided to do this in a separate one.