feat: Add full cost_class details per intervention to get_places_costs() output (SNT-225)#40
Open
feat: Add full cost_class details per intervention to get_places_costs() output (SNT-225)#40
get_places_costs() output (SNT-225)#40Conversation
bramj
force-pushed
the
SNT-225-second-attempt
branch
from
eac4edd to
63b6aa1
Compare
…ts()` output (SNT-225)
bramj
force-pushed
the
SNT-225-second-attempt
branch
from
63b6aa1 to
73531dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement over the first attempt (#38)
We basically add the full cost breakdown per OU to the payload, giving us full flexibility to display filtered graphs:
{ "place": 1071, "total_cost": 238501.72710000005, "interventions": [ { "type": "R21", "code": "vacc", "total_cost": 238501.72710000005, # Additional payload: "cost_breakdown": [ {"cost_class": "Operational", "cost": 12822.6735}, {"cost_class": "Procurement", "cost": 225679.05360000004}, ], } ], }