Conversation
| New variables can be supported by appending its identifier | ||
| to the `variables` list in `era5_extract()`. See documentation of `openhexa.toolbox.era5` for more | ||
| info on available variables. | ||
| info on available variables. (EM: perhaps here we should add a direct URL link) |
There was a problem hiding this comment.
In the section Suported variables would be handy to add a link to the toolbox documentation :
| * `2m_temperature` | ||
| * `total_precipitation` | ||
| * `volumetric_soil_water_layer_1` | ||
| * `volumetric_soil_water_layer_1` (EM: variables supported updated?) |
There was a problem hiding this comment.
I just saw that in the code we have:
@parameter(
"variable",
name="Variable",
type=str,
choices=[
"10 metre U wind component",
"10 metre V wind component",
"2 metre temperature",
"Total precipitation",
"Volumetric soil water layer 11",
]
perhaps we need to update this?
| ## Parameters | ||
| ## Parameters | ||
|
|
||
| (EM: Maybe here we can add a screenshot of the parameters?) |
There was a problem hiding this comment.
I would just add a screenshot with the pipelines parameters filled in as an example... just to keep the same style as other readme files I've seen ;)
|
Additional comments: I just had a couple of doubts:
|
lgarridobsq
left a comment
There was a problem hiding this comment.
Holi, I change the name because I wanted to see if I could link it to the JIRA issue this way -- it worked ⭐ remember that doing it by including the jira code in the branch name also works
I let Yann review the PR
I just created this PR for the purpose of adding my quick review of the ERA5 docs.