Open
Conversation
quang-le
requested changes
Feb 16, 2026
.../js/apps/Iaso/domains/forms/components/CreateSubmissionModal/CreateSubmissionModalButton.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/instances/components/CreateReAssignDialogComponent.tsx
Outdated
Show resolved
Hide resolved
quang-le
requested changes
Feb 16, 2026
Member
quang-le
left a comment
There was a problem hiding this comment.
(and tell the user that there's not yet xlsform uploaded) ==> This part of the feature is missing.
Please add a tooltip with the appropriate message when the icon button is disabled
quang-le
approved these changes
Feb 20, 2026
| type Props = { | ||
| onClick: () => void; | ||
| disabled?: boolean; | ||
| disabled: false; |
Member
There was a problem hiding this comment.
The previous typing was correct: you set a default value, but we can still pass true
Member
There was a problem hiding this comment.
Suggested change
| disabled: false; | |
| disabled?:boolean; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
This PR is about solving the issue of a user trying to create an instance from a form without latest version.
Related JIRA tickets
IA-4596
Changes
Explain the changes that were made.
Exported the props from
hat/assets/js/apps/Iaso/domains/instances/Components/CreateReassignDialogComponent.tsxto pass them in the modal inhat/assets/js/apps/Iaso/domains/instances/Components/CreateSubmissionModal.tsx. This allowed the definition of the ButtonProps with a disabled attribute which is used to check if a form has a version or not inhat/assets/js/apps/Iaso/domains/forms/components/FormActions.tsxHow to test
docker compose -f docker-compose.yml -f docker/docker-compose-enketo.yml upThe 'add submission' button should be disabled
Print screen / video
Notes
Things that the reviewers should know:
Doc
Tell us where the doc can be found (docs folder, wiki, in the code...).