-
Notifications
You must be signed in to change notification settings - Fork 70
Document Azure Table API datetime filter format and add validation tests #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: philnach <[email protected]>
Co-authored-by: philnach <[email protected]>
|
@copilot Should any of the queries worked that the issue file listed in the issue: #58 (comment)? |
No, the query shown in the issue would not have worked. The configuration had three problems:
The correct format would be: "QueryFilter": "Timestamp eq datetime\u00272021-07-26T10:31:05Z\u0027"All three issues needed to be fixed for the query to work. |
|
@copilot In the PR can you specifically call out in a table format the issue for each of the lines called out in the original issue. Here's that text so you don't have to look it up: "QueryFilter": "Timestamp ge datetime\u00272023-05-17T03:06:07.691Z\u0027" Success Transfer, Still no data in json file Look at each line and turn it into table with columns for the 3 problems you see are typical. Missing datetime, date format (not ISO 8601) and incorrect encoding. |
Co-authored-by: philnach <[email protected]>
Added a comprehensive troubleshooting table to the README in commit 225fab4. The table analyzes all 15 query filters from the issue with columns for:
Key findings:
The table is in the "Troubleshooting Common DateTime Filter Issues" section of Extensions/AzureTableAPI/README.md. |
philnach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have a good extensive documentation and tests. I can see how it's easy to make a mistake when you are supplying the query through JSON.
|
@markjbrown / @bowencode , Copilot added some good documentation to clarify how to query with DateTime, which I'd imagine is a pretty common QueryFilter. |
markjbrown
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Users reported timestamp query filters producing empty results despite successful migration completion. The
QueryFilterproperty requires specific OData datetime syntax with JSON escaping that was undocumented.Changes
Documentation (
README.md,ExampleConfigs.md)\u0027)datetimeprefix requirementTests (
AzureTableAPIDataSourceExtensionTests.cs)eq,ge,lt, range queries, combined filtersCorrect Format
{ "QueryFilter": "Timestamp ge datetime\u00272023-05-15T03:30:32.663Z\u0027" }Key requirements:
datetimeprefix before timestamp valueYYYY-MM-DDTHH:mm:ss.fffZ\u0027(not literal')Common Mistakes
Troubleshooting Table
The README now includes a comprehensive table that analyzes each of the 15 query filters attempted in the original issue, identifying specific problems with each attempt:
datetimeprefix is present or missingThis table helps users diagnose why their datetime filters may not be working and provides clear guidance on the correct format.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.