-
Notifications
You must be signed in to change notification settings - Fork 68
Soft deprecate azure-resource-provider-folder and remove from feeds #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Soft deprecate azure-resource-provider-folder and remove from feeds #3836
Conversation
commit: |
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
| ? "preview" | ||
| : "stable" | ||
| : undefined, | ||
| "version-status": version?.includes("preview") ? "preview" : "stable", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this safe, since version is only set on L356, if azureResourceProviderFolder is set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it didn't actually matter because the version is always set as the parameter when it matters. This is only in the case where it was set via the openapi3 @info decorator which should never happen.
But yeah good to remove the condition.
…eprecate-arm-resource-provider-folder
…eprecate-arm-resource-provider-folder
Right now this just document as deprecated but doesn't flag a warning as we are still deciding if we should fix v1 spec or wait until they are migrated.