[tcgc] add @clientOption decorator
#3827
Conversation
iscai-msft
requested review from
bterlson,
joheredi,
lmazuel,
m-nash,
markcowl,
srnagar and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
|
All changed packages have been documented.
Show changes
|
| it("multiple same decorators", async function () { | ||
| it("multiple same decorators with matching scope", async function () { | ||
| runner = await createSdkTestRunner( | ||
| {}, |
There was a problem hiding this comment.
we always default to csharp (see here) so this is actually testing that all scopes are returned in .decorators even if it doesn't match the emitter. I don't think this is what we should be doing, see my other comment
| getDecoratorArgValue(context, decorator.args[i].jsValue, type, decoratorName), | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
@tadelesh is there a reason we didn't filter raw decorators by scope before? I think we should because we only want actionable decorator values for a language emitter
There was a problem hiding this comment.
Oh, that's a logic missing. Good catch. Thanks for the fix.
|
You can try these changes here
|
tadelesh
left a comment
tadelesh
left a comment
There was a problem hiding this comment.
Shall we export client option in TCGC type graph? Current way seems not very convenient for language emitter.
| getDecoratorArgValue(context, decorator.args[i].jsValue, type, decoratorName), | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Oh, that's a logic missing. Good catch. Thanks for the fix.
| * } | ||
| * ``` | ||
| */ | ||
| extern dec clientOption(target: unknown, name: valueof string, value: unknown, scope?: valueof string); |
There was a problem hiding this comment.
Shall we limit the value to value type?
|
And could you merge main and migrate to use new testing framework? |
| * @example Apply an experimental option for Python | ||
| * ```typespec | ||
| * #suppress "@azure-tools/typespec-client-generator-core/client-option" | ||
| * @clientOption("enableFeatureFoo", true, "python") |
There was a problem hiding this comment.
can we add a link to the website with a dedicated place where we can define what are the options and values
| * | ||
| * @example Apply an experimental option for Python | ||
| * ```typespec | ||
| * #suppress "@azure-tools/typespec-client-generator-core/client-option" |
There was a problem hiding this comment.
Show example of the suppression with a message
4 participants
fixes #2228