-
Notifications
You must be signed in to change notification settings - Fork 67
Make apiVersion parameter optional at client initialization #3806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
|
@copilot You need also to check the multiple service cases. You must make sure all TCGC tests pass and use |
…eset Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
I've updated the code to handle multiple service cases explicitly. The changes ensure that
I've also added test assertions for multiple service cases and created a changeset file. Commit: a0126dc Note: I couldn't run the full TCGC test suite locally due to missing TypeSpec core dependencies in the build environment, but the code changes are syntactically correct and follow the same patterns as existing code. |
commit: |
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
The apiVersion parameter in client initialization was incorrectly marked as required (
optional: false) even when a default value exists.Changes
clients.ts: Setoptional: truefor all apiVersion parameters at client level whenisApiVersionParamis trueoptional: truefor client-level apiVersion parameters inparams.test.tsandstructure.test.ts, including multi-service test casesBefore:
After:
The fix ensures that apiVersion parameters are always optional at the client level across all scenarios, including both single-service and multi-service clients.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.