-
Notifications
You must be signed in to change notification settings - Fork 68
Add crossLanguageDefinitionId to SdkEnumValueType #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: iscai-msft <[email protected]>
…opilot/add-cross-language-id-to-enum
commit: |
tadelesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. But I'm wondering if we need to move crossLanguageDefinitionId to the base type.
packages/typespec-client-generator-core/test/decorators/client-location.test.ts
Outdated
Show resolved
Hide resolved
|
if we added it to the base type, then we should also have credential, endpoint, tuple, and dictionary types taking on cross language definition id. I think for those it largely makes sense not to have a cross language definition id |
…opilot/add-cross-language-id-to-enum
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
Enum values are referencable entities but lacked
crossLanguageDefinitionId, inconsistent with other SDK types.Changes
crossLanguageDefinitionId: stringproperty toSdkEnumValueTypeinterfacegetCrossLanguageDefinitionId()to acceptEnumMemberand generate IDs in formatParentEnum.memberNamecrossLanguageDefinitionIdingetSdkEnumValueWithDiagnostics()andgetSdkUnionEnumValues()Example
For enum
WidgetService.Color { Red, Green, Blue }:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build/usr/local/bin/node node /home/REDACTED/work/typespec-azure/typespec-azure/core/website/node_modules/.bin/../astro/astro.js build sh core�� ebsite/src/content/docs/docs/emitters/openapi3/reference node s/.bin/sh warn-as-error --sh . rsioning/referentspd doc . --enable-experimental --output-dir ../../website/src/content/docs/d--output-dir node core�� --noEmit node core/node_modules/.bin/node lint-typespec-liuname pnpm s/.bin/sh tp/reference(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
enumvaluetypes should havecrossLanguageDefinitionId#2834💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.