[JS] Update Documentation for JS Emitter to use Modular as default in client generation #3701
+225
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
qiaozha
reviewed
Jan 23, 2026
| ```typescript | ||
| JS RLC is not in the business of customization with client.tsp | ||
| // NOT_SUPPORTED |
Member
There was a problem hiding this comment.
We don't support overrider or sharedRoute in Modular?
Member
Author
There was a problem hiding this comment.
We support override and sharedRoute in Modular, but we do not support using @clientName to rename two operations to have the same name.
Member
There was a problem hiding this comment.
Can you create an issue for that? Thanks.
website/src/content/docs/docs/howtos/Generate client libraries/05pagingOperations.mdx
Show resolved
Hide resolved
website/src/content/docs/docs/howtos/Generate client libraries/08types.mdx
Show resolved
Hide resolved
website/src/content/docs/docs/howtos/Generate client libraries/00howtogen.mdx
Outdated
Show resolved
Hide resolved
qiaozha
approved these changes
Jan 27, 2026
| ```typescript | ||
| JS RLC is not in the business of customization with client.tsp | ||
| // NOT_SUPPORTED |
Member
There was a problem hiding this comment.
Can you create an issue for that? Thanks.
qiaozha
requested review from
bterlson,
markcowl and
timotheeguerin
as code owners
lirenhe
reviewed
Jan 27, 2026
|
|
||
| ```typescript | ||
| // TODO | ||
| // Modular api layer |
Member
There was a problem hiding this comment.
If I remember correctly, previously, Jose suggest we call it JS CodeGen instead of Modular, can we try to avoid using Modular in public docs?
lirenhe
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3634