fix ms pods stuck due to cilium image pull affected by firewall config #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vittoriasalim
requested review from
anson627,
sumanthreddy29,
wonderyl and
xinWeiWei24
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where Microsoft pods were stuck due to Cilium image pull failures caused by restrictive firewall configuration. The change adds Microsoft Container Registry (MCR) FQDNs to the Azure Firewall's allowed egress list.
Changes:
- Adds
mcr.microsoft.comand*.mcr.microsoft.comto the firewall allow list to enable Cilium container image pulls from Microsoft Container Registry
| target_fqdns = ["*.azure.com", "*.azure.net", | ||
| "*.windows.net", "*.azurecr.io", "*.ubuntu.com", "AzureKubernetesService", | ||
| "mcr-0001.mcr-msedge.net", "*.microsoft.com", | ||
| "mcr-0001.mcr-msedge.net", "*.microsoft.com", "mcr.microsoft.com", "*.mcr.microsoft.com", |
There was a problem hiding this comment.
The FQDN mcr.microsoft.com is redundant because it's already covered by the existing *.microsoft.com wildcard pattern. The wildcard *.microsoft.com matches any subdomain of microsoft.com, including mcr.microsoft.com. You can remove mcr.microsoft.com from this list while keeping *.mcr.microsoft.com to allow subdomains of mcr.microsoft.com (e.g., <region>.mcr.microsoft.com).
Suggested change
| "mcr-0001.mcr-msedge.net", "*.microsoft.com", "mcr.microsoft.com", "*.mcr.microsoft.com", | |
| "mcr-0001.mcr-msedge.net", "*.microsoft.com", "*.mcr.microsoft.com", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title