Skip to content

Conversation

@shalier
Copy link

@shalier shalier commented Jan 15, 2026

PR Description

New Feature Checklist

  • List telemetry added about the feature.
  • Link to the one-pager about the feature.
  • List any tasks necessary for release (3P docs, AKS RP chart changes, etc.) after merging the PR.
  • Attach results of scale and perf testing.

Tests Checklist

  • Have end-to-end Ginkgo tests been run on your cluster and passed? To bootstrap your cluster to run the tests, follow these instructions.
    • Labels used when running the tests on your cluster:
      • operator
      • windows
      • arm64
      • arc-extension
      • fips
  • Have new tests been added? For features, have tests been added for this feature? For fixes, is there a test that could have caught this issue and could validate that the fix works?

@shalier shalier marked this pull request as ready for review January 21, 2026 20:31
@shalier shalier requested a review from a team as a code owner January 21, 2026 20:31
@shalier shalier force-pushed the shalier/add-controlplaneistio branch from 6e08df7 to f9bbe8b Compare January 22, 2026 22:38
}
defaultConfigs = append(defaultConfigs, controlplaneEtcdDefaultFile)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are supposed to be prometheus-config-merger.go

@rashmichandrashekar
Copy link
Contributor

@shalier - Could you pls add description of what you are trying to do and what metrics are being scraped with these jobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants