Skip to content

fix: correct 'seletor' typo to 'selector' in struct tags and examples #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xinWeiWei24 merged 1 commit into from
Dec 15, 2025
Merged

fix: correct 'seletor' typo to 'selector' in struct tags and examples #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/types/load_traffic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ type RequestList struct {
// Limit defines the page size.
Limit int `json:"limit" yaml:"limit"`
// Selector defines how to identify a set of objects.
Selector string `json:"seletor" yaml:"seletor"`
Selector string `json:"selector" yaml:"selector"`
// FieldSelector defines how to identify a set of objects with field selector.
FieldSelector string `json:"fieldSelector" yaml:"fieldSelector"`
}
Expand Down
6 changes: 3 additions & 3 deletions api/types/load_traffic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
version: v1
resource: pods
namespace: default
seletor: app=x2
selector: app=x2
fieldSelector: spec.nodeName=x
shares: 200
- quorumList:
Expand All @@ -50,7 +50,7 @@ spec:
resource: configmaps
namespace: default
limit: 10000
seletor: app=x3
selector: app=x3
shares: 400
- put:
group: core
Expand All @@ -73,7 +73,7 @@ spec:
version: v1
resource: pods
namespace: default
seletor: app=x2
selector: app=x2
fieldSelector: spec.nodeName=x
shares: 250
`
Expand Down
2 changes: 1 addition & 1 deletion contrib/internal/manifests/loadprofile/node100_pod10k.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ loadProfile:
# including kubelet, when they want to get pods from ETCD. The limit
# is 100 because it's close to MaxPods value.
limit: 100
seletor: "app=benchmark"
selector: "app=benchmark"
shares: 200 # 200 / (1000 + 100 + 200) * 10 = 1.5 req/s
6 changes: 3 additions & 3 deletions docs/runkperf.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ You will see that summary when runners finish, like
"resource": "pods",
"namespace": "",
"limit": 0,
"seletor": "",
"selector": "",
"fieldSelector": ""
}
},
Expand All @@ -110,7 +110,7 @@ You will see that summary when runners finish, like
"resource": "pods",
"namespace": "",
"limit": 1000,
"seletor": "",
"selector": "",
"fieldSelector": ""
}
},
Expand All @@ -122,7 +122,7 @@ You will see that summary when runners finish, like
"resource": "events",
"namespace": "",
"limit": 1000,
"seletor": "",
"selector": "",
"fieldSelector": ""
}
}
Expand Down
Loading