feat: Support specifying OS disk type #1339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-hunt-materialize
force-pushed
the
specify_disk_type
branch
from
4604e88 to
28c54ca
Compare
Adds a new `osDiskType` enum field to the AKSNodeClass spec, with two variants: * `EphemeralWithFallbackToManaged` This is the default and matches the current behavior. * `Managed` This explicitly forces use of a managed disk, even if the instance type supports ephemeral disks large enough to be used as the OS disk.
alex-hunt-materialize
force-pushed
the
specify_disk_type
branch
from
28c54ca to
6d6a50b
Compare
This was referenced Jan 8, 2026
Author
|
@microsoft-github-policy-service agree company="Materialize" |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
osDiskTypeenum field to the AKSNodeClass spec, with two variants:EphemeralWithFallbackToManagedThis is the default and matches the current behavior.
ManagedThis explicitly forces use of a managed disk, even if the instance type supports ephemeral disks large enough to be used as the OS disk.
Partially addresses #1247.
While this does not implement the suggested solution in that issue, it does provide a better alternative than creating a massive OS disk.
This also relates to #801, and conflicts with #1256.
I think that PR should be updated to instead use a field name such as
osManagedDiskStorageAccountTypeto better match the storage profile field names.How was this change tested?
Does this change impact docs?
Release Note