-
Notifications
You must be signed in to change notification settings - Fork 104
BREAKING CHANGE: restrict taints and startupTaints for the domain "kubernetes.azure.com" #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charliedmcb
wants to merge
24
commits into
main
Choose a base branch
from
charliedmcb/addTaintRestrictionForAzureDomain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c9158a.
Base automatically changed from
charliedmcb/fixLabels+RequirementsCelTesting
to
main
September 17, 2025 21:13
tallaxes
previously approved these changes
Sep 18, 2025
Collaborator
tallaxes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation LGTM. In the larger picture, I have some concerns surrounding implicit application of taints in general (Karpenter - or any autoscaler - needs to be aware of expected taints), and spot-specific taint in particular (breaks mixed nodepools); discussing offline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Restricting the domain of taints, and startupTaints for the domain "kubernetes.azure.com".
This is to align with AKS validation of taints, and usage of well-known taints.
Note: had to restrict taints to a max of 100 to work within CEL validation time complexity limits
Broken off fixing the cel validation for labels and requirements into separate PR here:
How was this change tested?
Manually tested impact of having these CRDs applied, if there was an existing non-compliant NodePool, and found the following:


(1) A warning will be returned on an update that doesn't modify the taint:
(2) An error will be returned if the taint is removed, and then attempted to be reapplied:
E2E runs:
Does this change impact docs?
Release Note