Fix structurally wrong dab init --graphql.multiple-create.enabled#3407
Open
souvikghosh04 wants to merge 1 commit intomainfrom
Open
Fix structurally wrong dab init --graphql.multiple-create.enabled#3407souvikghosh04 wants to merge 1 commit intomainfrom
souvikghosh04 wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dab init CLI option name for enabling GraphQL multiple-create mutations to match the runtime configuration structure (multiple-mutations.create.enabled) and aligns related messaging/tests accordingly.
Changes:
- Renames the
dab initflag from--graphql.multiple-create.enabledto--graphql.multiple-mutations.create.enabled. - Updates warnings/comments and CLI tests to use the new flag name.
- Updates the MSSQL config-generator command file to use the new flag name.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Cli/ConfigGenerator.cs | Updates warning/help text references to the new CLI option name. |
| src/Cli/Commands/InitOptions.cs | Renames the init option attribute string to the new flag name. |
| src/Cli.Tests/InitTests.cs | Updates test documentation and DataRow display names to the new flag. |
| src/Cli.Tests/EndToEndTests.cs | Updates end-to-end CLI argument construction and assertions to the new flag. |
| config-generators/mssql-commands.txt | Updates generated MSSQL init command to use the new flag. |
souvikghosh04
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
RubenCerna2079,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
stuartpa and
vadeveka
as code owners
Aniruddh25
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
dab initused a flat, structurally wrong option--graphql.multiple-create.enabledwhile the JSON schema anddab configureboth use the correct nested structure--runtime.graphql.multiple-mutations.create.enabled.What is this change?
dab initCLI option from--graphql.multiple-create.enabledto--graphql.multiple-mutations.create.enabledto align with the config schema hierarchy (runtime.graphql.multiple-mutations.create.enabled) anddab configure.MultipleMutationOptions/MultipleCreateOptionswas already correct.--graphql.multiple-create.enabledis no longer accepted bydab init. Users should migrate to--graphql.multiple-mutations.create.enabled.How was this tested?
Sample Request(s)
Before (broken):
After (fixed):