Skip to content

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Jan 27, 2026

Description

Updates Admin continuation tokens to match the new format from Core.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp requested a review from xiangyan99 January 27, 2026 19:59
@mccoyp mccoyp requested a review from a team as a code owner January 27, 2026 19:59
Copilot AI review requested due to automatic review settings January 27, 2026 19:59
@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jan 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the continuation token format in the Azure Key Vault Administration library to match the new format from Azure Core. The change replaces pickle-based serialization with JSON-based serialization for improved security and compatibility.

Changes:

  • Updated minimum azure-core dependency from 1.31.0 to 1.38.0
  • Replaced pickle serialization with JSON serialization for continuation tokens
  • Added new _get_continuation_token() helper function that creates JSON-based tokens with versioned schema
  • Modernized super() call in KeyVaultBackupClientPolling
  • Added comprehensive documentation for the continuation token approach

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/keyvault/azure-keyvault-administration/setup.py Bumped minimum azure-core version to 1.38.0
sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_backup_client.py Replaced pickle with json import; added _get_continuation_token() function implementing new JSON-based token format; added type annotations to _parse_status_url()
sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/aio/_backup_client.py Removed pickle import; imported and used _get_continuation_token() from sync module
sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/polling.py Modernized super() call; added comprehensive docstring to get_continuation_token() method
sdk/keyvault/azure-keyvault-administration/CHANGELOG.md Documented continuation token format change and azure-core version update

mccoyp and others added 3 commits January 27, 2026 13:43
…nistration/_backup_client.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

1 participant