-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Key Vault] Update continuation tokens #44879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the continuation token format in the Azure Key Vault Administration library to match the new format from Azure Core. The change replaces pickle-based serialization with JSON-based serialization for improved security and compatibility.
Changes:
- Updated minimum
azure-coredependency from 1.31.0 to 1.38.0 - Replaced pickle serialization with JSON serialization for continuation tokens
- Added new
_get_continuation_token()helper function that creates JSON-based tokens with versioned schema - Modernized
super()call inKeyVaultBackupClientPolling - Added comprehensive documentation for the continuation token approach
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/keyvault/azure-keyvault-administration/setup.py | Bumped minimum azure-core version to 1.38.0 |
| sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_backup_client.py | Replaced pickle with json import; added _get_continuation_token() function implementing new JSON-based token format; added type annotations to _parse_status_url() |
| sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/aio/_backup_client.py | Removed pickle import; imported and used _get_continuation_token() from sync module |
| sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/polling.py | Modernized super() call; added comprehensive docstring to get_continuation_token() method |
| sdk/keyvault/azure-keyvault-administration/CHANGELOG.md | Documented continuation token format change and azure-core version update |
sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_backup_client.py
Outdated
Show resolved
Hide resolved
…nistration/_backup_client.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
Updates Admin continuation tokens to match the new format from Core.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines