Skip to content

Conversation

@rads-1996
Copy link
Member

@rads-1996 rads-1996 commented Jan 23, 2026

No description provided.

@github-actions github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Jan 23, 2026
@rads-1996 rads-1996 force-pushed the fix-new-pylint-version-errors branch from a538e25 to 2eb01ac Compare January 23, 2026 19:30
@rads-1996 rads-1996 changed the title Fix new pylint version 4.0.4 errors Fix new pylint version 4.0.4 errors in exporter Jan 23, 2026
@rads-1996 rads-1996 force-pushed the fix-new-pylint-version-errors branch from 532cd4f to e658207 Compare January 26, 2026 23:30
@rads-1996 rads-1996 force-pushed the fix-new-pylint-version-errors branch from e658207 to 574f4a5 Compare January 27, 2026 19:51
@rads-1996 rads-1996 marked this pull request as ready for review January 27, 2026 20:15
Copilot AI review requested due to automatic review settings January 27, 2026 20:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses pylint 4.0.4 compatibility issues across the azure-monitor-opentelemetry-exporter package. The changes are purely maintenance-focused to resolve new linting errors introduced in pylint version 4.0.4.

Changes:

  • Added appropriate pylint disable comments for valid suppressions (name-too-long, unused-argument, protected-access, etc.)
  • Fixed mutable default arguments (e.g., headers={} changed to headers=None)
  • Added missing self parameters to class methods
  • Prefixed unused variables with underscore
  • Reformatted long lines and strings to comply with line length limits
  • Reordered imports to follow proper conventions

Reviewed changes

Copilot reviewed 76 out of 76 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test files (tests/*) Added pylint disable comments for test-specific patterns like name-too-long, too-many-public-methods, protected-access, and prefixed unused mock parameters with underscore
test_base_exporter.py Fixed mutable default argument in MockResponse.init and added missing self parameter to mock class methods
test_storage.py Uncommented assertion that was previously disabled, fixed isinstance checks, and added broad-exception-caught disables
sample files (samples/*) Reordered imports to follow proper conventions and added pylint disable comments for sample-specific patterns
statsbeat/_utils.py Added do-not-log-exceptions-if-not-debug disables for warning logs with exceptions
export/_base.py Added do-not-log-exceptions-if-not-debug and do-not-use-logging-exception disables, plus unidiomatic-typecheck for valid type(None) check
_quickpulse/_exporter.py Added do-not-log-exceptions-if-not-debug disables for exception logging
_performance_counters/_manager.py Added do-not-use-logging-exception disables for logger.exception calls
_configuration/*.py Added do-not-log-exceptions-if-not-debug disables for exception warning logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Exporter Monitor OpenTelemetry Exporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant