-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix new pylint version 4.0.4 errors in exporter #44821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a538e25 to
2eb01ac
Compare
532cd4f to
e658207
Compare
e658207 to
574f4a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request addresses pylint 4.0.4 compatibility issues across the azure-monitor-opentelemetry-exporter package. The changes are purely maintenance-focused to resolve new linting errors introduced in pylint version 4.0.4.
Changes:
- Added appropriate pylint disable comments for valid suppressions (name-too-long, unused-argument, protected-access, etc.)
- Fixed mutable default arguments (e.g.,
headers={}changed toheaders=None) - Added missing
selfparameters to class methods - Prefixed unused variables with underscore
- Reformatted long lines and strings to comply with line length limits
- Reordered imports to follow proper conventions
Reviewed changes
Copilot reviewed 76 out of 76 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test files (tests/*) | Added pylint disable comments for test-specific patterns like name-too-long, too-many-public-methods, protected-access, and prefixed unused mock parameters with underscore |
| test_base_exporter.py | Fixed mutable default argument in MockResponse.init and added missing self parameter to mock class methods |
| test_storage.py | Uncommented assertion that was previously disabled, fixed isinstance checks, and added broad-exception-caught disables |
| sample files (samples/*) | Reordered imports to follow proper conventions and added pylint disable comments for sample-specific patterns |
| statsbeat/_utils.py | Added do-not-log-exceptions-if-not-debug disables for warning logs with exceptions |
| export/_base.py | Added do-not-log-exceptions-if-not-debug and do-not-use-logging-exception disables, plus unidiomatic-typecheck for valid type(None) check |
| _quickpulse/_exporter.py | Added do-not-log-exceptions-if-not-debug disables for exception logging |
| _performance_counters/_manager.py | Added do-not-use-logging-exception disables for logger.exception calls |
| _configuration/*.py | Added do-not-log-exceptions-if-not-debug disables for exception warning logs |
No description provided.