-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Adding the support for the microsoftteamsapp idenfier to add as participant and transfer #55159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…cipant and transfer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the MicrosoftTeamsAppIdentifier communication identifier type to the Call Automation SDK, enabling it to be used when adding participants and transferring calls.
Changes:
- Added new constructors to
TransferToParticipantOptionsandCallInviteclasses that acceptMicrosoftTeamsAppIdentifier - Updated API surface definitions across all target frameworks (netstandard2.0, net8.0, net10.0)
- Updated CHANGELOG with the new feature for version 1.5.1
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/communication/Azure.Communication.CallAutomation/src/Models/TransferToParticipantOptions.cs | Added constructor overload accepting MicrosoftTeamsAppIdentifier parameter |
| sdk/communication/Azure.Communication.CallAutomation/src/Models/CallInvite.cs | Added constructor overload accepting MicrosoftTeamsAppIdentifier parameter |
| sdk/communication/Azure.Communication.CallAutomation/api/Azure.Communication.CallAutomation.netstandard2.0.cs | Updated API surface to include new constructors |
| sdk/communication/Azure.Communication.CallAutomation/api/Azure.Communication.CallAutomation.net8.0.cs | Updated API surface to include new constructors |
| sdk/communication/Azure.Communication.CallAutomation/api/Azure.Communication.CallAutomation.net10.0.cs | Updated API surface to include new constructors |
| sdk/communication/Azure.Communication.CallAutomation/CHANGELOG.md | Added entry for version 1.5.1 documenting MicrosoftTeamsAppIdentifier support |
sdk/communication/Azure.Communication.CallAutomation/src/Models/TransferToParticipantOptions.cs
Show resolved
Hide resolved
sdk/communication/Azure.Communication.CallAutomation/src/Models/CallInvite.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.CallAutomation/src/Models/TransferToParticipantOptions.cs
Show resolved
Hide resolved
sdk/communication/Azure.Communication.CallAutomation/src/Models/CallInvite.cs
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
sdk/communication/Azure.Communication.CallAutomation/src/CallConnection.cs
Show resolved
Hide resolved
sdk/communication/Azure.Communication.CallAutomation/src/Models/CallInvite.cs
Show resolved
Hide resolved
|
@v-dharmarajv I've opened a new pull request, #55193, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@v-dharmarajv I've opened a new pull request, #55194, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Add parameter descriptions to CallInvite constructors Co-authored-by: v-dharmarajv <146493756+v-dharmarajv@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: v-dharmarajv <146493756+v-dharmarajv@users.noreply.github.com>
…/github.com/Azure/azure-sdk-for-net into users/v-dharmarajv/microsoftTeamsAppSupport
| /// <param name="targetIdentity">The Microsoft Teams App identifier of the target participant.</param> | ||
| public CallInvite(MicrosoftTeamsAppIdentifier targetIdentity) | ||
| { | ||
| Target = targetIdentity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we do null checking here?
| else if (targetParticipant is MicrosoftTeamsAppIdentifier) | ||
| { | ||
| options = new TransferToParticipantOptions(targetParticipant as MicrosoftTeamsAppIdentifier); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can do this with the rest of them too
| else if (targetParticipant is MicrosoftTeamsAppIdentifier) | |
| { | |
| options = new TransferToParticipantOptions(targetParticipant as MicrosoftTeamsAppIdentifier); | |
| } | |
| else if (targetParticipant is MicrosoftTeamsAppIdentifier mtai) | |
| { | |
| options = new TransferToParticipantOptions(mtai); | |
| } |
Adding the support for the microsoftteamsapp idenfier to add as participant and transfer