Onboarding Microsoft.FileShares in GO SDK #25928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the initial preview release of the Azure File Shares management library for Go, including changelog, license, readme, CI configuration, go.mod, and version definition files.
Renamed and relocated the armfileshares SDK package from sdk/storage/armfileshares to sdk/resourcemanager/fileshares/armfileshares. Updated import paths, CI configuration, and added new client, model, and test files to support the new location.
ankushbindlish2
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request onboards a new Azure SDK for Go management library for Microsoft.FileShares, enabling management of Azure File Shares resources through the Azure Resource Manager API.
Changes:
- Adds complete SDK module for armfileshares under sdk/resourcemanager/fileshares/armfileshares
- Implements management operations for file shares, snapshots, and informational queries
- Includes generated code from TypeSpec definitions with API version 2025-06-01-preview
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.go | Module version constants (v0.1.0) |
| tsp-location.yaml | TypeSpec location configuration |
| go.mod/go.sum | Module dependencies following SDK guidelines |
| client.go, operations_client.go, etc. | Generated client implementations |
| models.go, constants.go | Generated model and enum definitions |
| responses.go, options.go | Generated response/option types |
| models_serde.go | JSON serialization implementations |
| client_factory.go | Factory for creating clients |
| fake/*.go | Fake server implementations for testing |
| *_example_test.go | Generated example tests |
| README.md | Module documentation |
| CHANGELOG.md | Release history |
| LICENSE.txt | MIT license |
| ci.yml | CI/CD pipeline configuration |
Member
Author
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.