Skip to content

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented Jan 23, 2026

…0 generation from spec commit: 6e34caed36815fc876c8e8c0371db76f809e52e8
@jliusan jliusan requested a review from lirenhe as a code owner January 23, 2026 02:40
Copilot AI review requested due to automatic review settings January 23, 2026 02:40
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jan 23, 2026
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/redhatopenshift/armredhatopenshift

@jliusan
Copy link
Member Author

jliusan commented Jan 23, 2026

The breaking changes are introduced and approved in this PR, @jhendrixMSFT , please approve this major version release by adding label of Approved Major Version, thanks.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Release PR for sdk/resourcemanager/redhatopenshift/armredhatopenshift v2.0.0, updating the SDK to the newer Swagger/API version and reshaping the surface area (new workload identity APIs, removed older subresources).

Changes:

  • Bumps module to v2.0.0 (Go module path /v2) and updates API version to 2025-07-25.
  • Adds Platform Workload Identity Role Set(s) clients, models, responses, and fakes.
  • Removes MachinePools/Secrets/Sync* clients, examples, models, and fakes.

Reviewed changes

Copilot reviewed 42 out of 43 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
sdk/resourcemanager/redhatopenshift/armredhatopenshift/version.go Adds v2 module name/version constants (used for client user-agent/versioning).
sdk/resourcemanager/redhatopenshift/armredhatopenshift/time_rfc3339.go Adjusts RFC3339 text unmarshalling behavior.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/syncsets_client_example_test.go Removes SyncSets examples.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/syncsets_client.go Removes SyncSets client.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/syncidentityproviders_client_example_test.go Removes SyncIdentityProviders examples.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/syncidentityproviders_client.go Removes SyncIdentityProviders client.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/secrets_client_example_test.go Removes Secrets examples.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/secrets_client.go Removes Secrets client.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/responses.go Removes old response types; adds new response types for new APIs.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/platformworkloadidentityrolesets_client_example_test.go Adds example for listing workload identity role sets.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/platformworkloadidentityrolesets_client.go Adds client for listing workload identity role sets.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/platformworkloadidentityroleset_client_example_test.go Adds example for getting a workload identity role set.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/platformworkloadidentityroleset_client.go Adds client for getting a workload identity role set.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/options.go Removes options for removed clients; adds options for new APIs; tweaks comments.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/operations_client_example_test.go Updates example spec reference to new API version.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/operations_client.go Updates API version and comment style; minor signature tweaks.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/openshiftversions_client_example_test.go Updates examples; adds Get example.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/openshiftversions_client.go Adds Get operation; updates API version/path.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/openshiftclusters_client.go Updates to API version 2025-07-25 and adjusts request helpers.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/models.go Updates models: adds workload identity/MSI types; removes old resource types.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/machinepools_client.go Removes MachinePools client.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/go.sum Updates dependency hashes for v2 and new generated surface.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/go.mod Moves module to /v2 and updates dependencies.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/time_rfc3339.go Removes old fake time helper (no longer generated/needed).
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/syncsets_server.go Removes SyncSets fake server.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/syncidentityproviders_server.go Removes SyncIdentityProviders fake server.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/server_factory.go Updates fake server factory to match the new client set.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/secrets_server.go Removes Secrets fake server.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/platformworkloadidentityrolesets_server.go Adds fake server for listing workload identity role sets.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/platformworkloadidentityroleset_server.go Adds fake server for getting a workload identity role set.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/operations_server.go Updates operations fake server structure (interceptor/dispatch changes).
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/openshiftversions_server.go Adds Get fake and updates paths/dispatch patterns.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/openshiftclusters_server.go Updates fake server dispatch and expected status codes for delete, etc.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/machinepools_server.go Removes MachinePools fake server.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/fake/internal.go Adds shared result type used by new fake server dispatch logic.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/constants.go Removes old module constants; adds MSI enum values.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/client_factory.go Removes old client constructors; adds new workload identity clients.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/autorest.md Updates autorest config to v2.0.0 and new swagger tag.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/README.md Updates module install path and sample client usage.
sdk/resourcemanager/redhatopenshift/armredhatopenshift/CHANGELOG.md Adds 2.0.0 release notes (breaking changes + new features).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants