Skip to content

[Migrate-Check] sdk/resourcemanager/machinelearningservices/armmachinelearningservice Mgmt #25918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jliusan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Migrate-Check] sdk/resourcemanager/machinelearningservices/armmachinelearningservice Mgmt #25918

jliusan wants to merge 1 commit into from

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented Jan 22, 2026

generation based on spec branch mcgallan:Convert-MachineLearningServices-preview-10-01

Copilot AI review requested due to automatic review settings January 22, 2026 11:52
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jan 22, 2026
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/machinelearning/armmachinelearning

Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the Azure Machine Learning Services SDK from v4 to v5, updating the API version from 2024-04-01 to 2025-10-01-preview and changing the code generator from AutoRest to the Go Code Generator.

Changes:

  • Updated API version from 2024-04-01 to 2025-10-01-preview across all clients
  • Migrated code generation from AutoRest to Go Code Generator
  • Bumped module version from v4 to v5 and azcore dependency from v1.20.0 to v1.21.0
  • Added tsp-location.yaml for TypeSpec-based generation metadata
  • Updated client methods with improved documentation and parameter naming
  • Reorganized example tests with corrected response structures

Reviewed changes

Copilot reviewed 74 out of 223 changed files in this pull request and generated no comments.

Show a summary per file
File Description
version.go Added new file defining module version v5.0.0-beta.1
go.mod Updated module path to v5 and dependencies
tsp-location.yaml Added TypeSpec generation metadata
workspaces_client.go Updated API version, improved docs, added Content-Type headers
workspaces_client_example_test.go Updated examples with new API patterns and response structures
workspacefeatures_client.go Updated API version and improved parameter documentation
workspaceconnections_client.go Added new methods (TestConnection, Update), updated API version
virtualmachinesizes_client.go Updated API version and documentation
usages_client.go Updated API version and improved documentation
schedules_client.go Updated API version, improved documentation
serverlessendpoints_client_example_test.go Reorganized examples, added ContentSafetyLevel field
responses_serde.go Added custom unmarshalling for specific response types
time_rfc3339.go Removed custom time handling (likely moved to azcore)
testdata/_metadata.json Added metadata for API version and emitter version

jliusan
jliusan commented Jan 23, 2026
View reviewed changes
sdk/resourcemanager/machinelearning/armmachinelearning/CHANGELOG.md
- Field `Value`, `ValueFormat` of struct `UsernamePasswordAuthTypeWorkspaceConnectionProperties` has been removed
- Field `Value`, `ValueFormat` of struct `WorkspaceConnectionPropertiesV2` has been removed
- Field `Parameters` of struct `WorkspacesClientBeginDiagnoseOptions` has been removed

Copy link
Member Author

@jliusan jliusan Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Breaking Changes:

  • Type of ComputeInstanceContainer.Services has been changed from []any to []map[string]any （fixed and disappeared）

  • Type of ComputeInstanceContainer.Services has been changed from []any to []map[string]anyfixed and disappeared）

  • Type of PipelineJob.Settings has been changed from any to map[string]anyfixed and disappeared）

  • Type of SweepJob.SearchSpace has been changed from any to map[string]anyfixed and disappeared）

  • Struct AKSSchema has been removed

  • Struct AksComputeSecretsProperties has been removed

  • Struct AmlComputeSchema has been removed

  • Struct AssetBase has been removed

  • Struct AssetContainer has been removed

  • Struct AssetJobInput has been removed

  • Struct AssetJobOutput has been removed

  • Struct DataLakeAnalyticsSchema has been removed

  • Struct DatabricksSchema has been removed

  • Struct EndpointDeploymentPropertiesBase has been removed

  • Struct EndpointPropertiesBase has been removed

  • Struct FeaturizationSettings has been removed

  • Struct HDInsightSchema has been removed

  • Struct ImageClassificationBase has been removed

  • Struct ImageModelDistributionSettings has been removed

  • Struct ImageModelSettings has been removed

  • Struct ImageObjectDetectionBase has been removed

  • Struct ImageVertical has been removed

  • Struct KubernetesSchema has been removed

  • Struct NlpVertical has been removed

  • Struct PartialMinimalTrackedResource has been removed

  • Struct PrivateEndpoint has been removed

  • Struct ProxyResource has been removed

  • Struct Resource has been removed

  • Struct ResourceBase has been removed

  • Struct ResourceConfiguration has been removed

  • Struct TableVertical has been removed

  • Struct TrackedResource has been removed

  • Struct TrainingSettings has been removed

  • Struct VirtualMachineSchema has been removed

  • Struct VirtualMachineSecretsSchema has been removed

  • Function *WorkspaceConnectionsClient.Create parameter(s) have been changed from (ctx context.Context, resourceGroupName string, workspaceName string, connectionName string, parameters WorkspaceConnectionPropertiesV2BasicResource, options *WorkspaceConnectionsClientCreateOptions) to (ctx context.Context, resourceGroupName string, workspaceName string, connectionName string, options *WorkspaceConnectionsClientCreateOptions)
    changed to

  • Function *WorkspaceConnectionsClient.Create parameter(s) have been changed from (ctx context.Context, resourceGroupName string, workspaceName string, connectionName string, parameters WorkspaceConnectionPropertiesV2BasicResource, options *WorkspaceConnectionsClientCreateOptions) to (ctx context.Context, resourceGroupName string, workspaceName string, connectionName string, body WorkspaceConnectionPropertiesV2BasicResource, options *WorkspaceConnectionsClientCreateOptions)

Copy link
Member Author

@jliusan jliusan Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Features Added updated:

functions changed:
1、- New function *ConnectionRaiBlocklistItemClient.BeginDeleteBulk(ctx context.Context, resourceGroupName string, workspaceName string, connectionName string, raiBlocklistName string, body any, options *ConnectionRaiBlocklistItemClientBeginDeleteBulkOptions) (*runtime.Poller[ConnectionRaiBlocklistItemClientDeleteBulkResponse], error)
changed to

  • New function *ConnectionRaiBlocklistItemClient.BeginDeleteBulk(ctx context.Context, resourceGroupName string, workspaceName string, connectionName string, raiBlocklistName string, body []*string, options *ConnectionRaiBlocklistItemClientBeginDeleteBulkOptions) (*runtime.Poller[ConnectionRaiBlocklistItemClientDeleteBulkResponse], error) (caused by definition error in swagger)

2、- New function *InferenceEndpointsClient.BeginUpdate(ctx context.Context, resourceGroupName string, workspaceName string, poolName string, endpointName string, body any, options *InferenceEndpointsClientBeginUpdateOptions) (*runtime.Poller[InferenceEndpointsClientUpdateResponse], error)
changed to

  • New function *InferenceEndpointsClient.BeginUpdate(ctx context.Context, resourceGroupName string, workspaceName string, poolName string, endpointName string, options *InferenceEndpointsClientBeginUpdateOptions) (*runtime.Poller[InferenceEndpointsClientUpdateResponse], error) (caused by definition error in swagger)

3、- New function *ManagedNetworkSettingsClient.BeginPatch(ctx context.Context, resourceGroupName string, workspaceName string, managedNetworkName string, options *ManagedNetworkSettingsClientBeginPatchOptions) (*runtime.Poller[ManagedNetworkSettingsClientPatchResponse], error)
changed to

  • New function *ManagedNetworkSettingsClient.BeginPatch(ctx context.Context, resourceGroupName string, workspaceName string, managedNetworkName string, body ManagedNetworkSettingsPropertiesBasicResource, options *ManagedNetworkSettingsClientBeginPatchOptions) (*runtime.Poller[ManagedNetworkSettingsClientPatchResponse], error)

4、- New function *WorkspaceConnectionsClient.Update(ctx context.Context, resourceGroupName string, workspaceName string, connectionName string, options *WorkspaceConnectionsClientUpdateOptions) (WorkspaceConnectionsClientUpdateResponse, error)
changed to

  • New function *WorkspaceConnectionsClient.Update(ctx context.Context, resourceGroupName string, workspaceName string, connectionName string, body WorkspaceConnectionUpdateParameter, options *WorkspaceConnectionsClientUpdateOptions) (WorkspaceConnectionsClientUpdateResponse, error)

Added:

  • New struct StringStringKeyValuePair
  • New field XMSAsyncOperationTimeout in struct BatchDeploymentsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct BatchDeploymentsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct BatchDeploymentsClientUpdateResponse
  • New field XMSAsyncOperationTimeout in struct BatchEndpointsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct BatchEndpointsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct BatchEndpointsClientUpdateResponse
  • New field XMSAsyncOperationTimeout in struct FeaturesetContainersClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct FeaturesetContainersClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct FeaturesetVersionsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct FeaturesetVersionsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct FeaturestoreEntityContainersClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct FeaturestoreEntityContainersClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct FeaturestoreEntityVersionsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct FeaturestoreEntityVersionsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct JobsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct MarketplaceSubscriptionsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct MarketplaceSubscriptionsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct OnlineDeploymentsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct OnlineDeploymentsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct OnlineDeploymentsClientUpdateResponse
  • New field XMSAsyncOperationTimeout in struct OnlineEndpointsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct OnlineEndpointsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct OnlineEndpointsClientUpdateResponse
  • New field NextLink in struct PrivateEndpointConnectionListResult
  • New field NextLink in struct PrivateLinkResourceListResult
  • New field XMSAsyncOperationTimeout in struct RegistriesClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistriesClientRemoveRegionsResponse
  • New field XMSAsyncOperationTimeout in struct RegistryCodeContainersClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryCodeContainersClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryCodeVersionsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryCodeVersionsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryComponentContainersClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryComponentContainersClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryComponentVersionsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryComponentVersionsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryDataContainersClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryDataContainersClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryDataVersionsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryDataVersionsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryEnvironmentContainersClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryEnvironmentContainersClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryEnvironmentVersionsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryEnvironmentVersionsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryModelContainersClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryModelContainersClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct RegistryModelVersionsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct RegistryModelVersionsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct SchedulesClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct SchedulesClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct ServerlessEndpointsClientCreateOrUpdateResponse
  • New field XMSAsyncOperationTimeout in struct ServerlessEndpointsClientDeleteResponse
  • New field XMSAsyncOperationTimeout in struct ServerlessEndpointsClientUpdateResponse

Copy link
Member Author

@jliusan jliusan Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature Added removed：

  • New struct CapacityConfig
  • New struct CognitiveServiceEndpointDeploymentResourceProperties
  • New struct PropertiesBase
  • New struct StringKeyValuePair
  • New field AssetName in struct AssetJobOutput (- Struct AssetJobOutput has been removed)
  • New field Body in struct WorkspaceConnectionsClientCreateOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

@JiaqiZhang-Dev JiaqiZhang-Dev Awaiting requested review from JiaqiZhang-Dev JiaqiZhang-Dev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jliusan