[Migrate-Check-Main-Branch] sdk/resourcemanager/marketplace/armmarketplace #25907
Conversation
…tion from spec commit: 74172b879dd046192dcf4f9efa1f8f0c561eba95
jliusan
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Pull request overview
This pull request migrates the Azure Marketplace SDK from API version 2021-12-01 to 2025-01-01, upgrading from v1.2.0 to v2.0.0. The changes include significant API updates with new clients, methods, and data structures, along with breaking changes to existing method signatures.
Changes:
- Major version bump to v2.0.0 with breaking changes to function parameter ordering
- Addition of RPServiceClient for rule management functionality
- New methods for collection management (ApproveAllItems, DisableApproveAllItems)
- Enhanced time handling with support for various datetime formats
Reviewed changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated module dependencies and version; contains critical issues |
| version.go | Added new file defining module version constants |
| CHANGELOG.md | Documents breaking changes and new features for v2.0.0 |
| README.md | Updated installation instructions for v2 module path |
| client_factory.go | Refactored to create RPServiceClient and optimize client creation |
| rpservice_client.go | New client for marketplace rule service operations |
| time_rfc3339.go | Enhanced datetime parsing with support for multiple formats |
| models.go | Added new data structures for rules, contexts, and multi-context operations |
| fake/* | Updated fake servers for testing with new interceptor pattern |
| @@ -1,21 +1,22 @@ | |||
| module github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/marketplace/armmarketplace | |||
| module github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/marketplace/armmarketplace/v2 | |||
There was a problem hiding this comment.
The module path in go.mod is inconsistent with the major version. For a v2 module, the module path should be github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/marketplace/armmarketplace/v2. The current path is missing the /v2 suffix.
| github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.13.1 | ||
| github.com/Azure/azure-sdk-for-go/sdk/azcore v1.21.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.10.1 | ||
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/marketplace/armmarketplace v1.2.0 |
There was a problem hiding this comment.
The go.mod file contains a self-reference to the v1.2.0 version of the same package. This creates a circular dependency and will cause build failures. This require statement should be removed since this is the package being built.
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/marketplace/armmarketplace v1.2.0 |
generation on main spec tag:package-2025-01-01