Skip to content

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented Jan 21, 2026

generation base on spec branch migration/marketplace

@jliusan jliusan requested a review from lirenhe as a code owner January 21, 2026 10:06
Copilot AI review requested due to automatic review settings January 21, 2026 10:06
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jan 21, 2026
@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/marketplace/armmarketplace

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the Azure Marketplace SDK from AutoRest code generation to the new Go Code Generator (TypeSpec-based), updating from API version 2021-12-01 to 2025-01-01 and bumping the major version from v1 to v2.

Changes:

  • Migration from AutoRest to TypeSpec-based Go Code Generator
  • API version update from 2021-12-01 to 2025-01-01
  • Module version bump to v2 with updated import paths
  • New operations and response types added
  • Method signature changes (some optional parameters moved to required)

Reviewed changes

Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
version.go New file defining module name and version v2.0.0
tsp-location.yaml New TypeSpec configuration file for SDK generation
testdata/_metadata.json New test metadata with API version 2025-01-01
time_rfc3339.go Removed (functionality likely moved to generated code)
responses.go Updated response types with new operations and improved comments
go.mod Updated module path to v2 and dependency versions
go.sum Updated dependency checksums
*_client.go Updated with API version changes, signature changes, and new methods
*_example_test.go Updated examples with new import path and API patterns
options.go Updated with new optional parameter structures
build.go Removed (no longer needed for TypeSpec generation)
fake/*.go Updated fake server implementations

- New struct `CollectionOffersByContext`
- New struct `CollectionOffersByContextList`
- New struct `CollectionOffersByContextOffers`
- New struct `CollectionsToSubscriptionsMappingResponseProperties`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature Migration Added:

  • New struct CollectionsToSubscriptionsMappingResponseProperties
  • New enum type CreatedByType with values CreatedByTypeApplication, CreatedByTypeKey, CreatedByTypeManagedIdentity, CreatedByTypeUser
    • New function NewClient(credential azcore.TokenCredential, options *arm.ClientOptions) (*Client, error)
  • New function *Client.NewOperationsClient() *OperationsClient
  • New function *Client.NewPrivateStoreClient() *PrivateStoreClient
  • New function *Client.NewPrivateStoreCollectionClient() *PrivateStoreCollectionClient
  • New function *Client.NewPrivateStoreCollectionOfferClient() *PrivateStoreCollectionOfferClient
  • New function *Client.QueryRules(ctx context.Context, privateStoreID string, collectionID string, options *ClientQueryRulesOptions) (ClientQueryRulesResponse, error)
  • New function *Client.QueryUserRules(ctx context.Context, privateStoreID string, options *ClientQueryUserRulesOptions) (ClientQueryUserRulesResponse, error)
  • New function *Client.SetCollectionRules(ctx context.Context, privateStoreID string, collectionID string, options *ClientSetCollectionRulesOptions) (ClientSetCollectionRulesResponse, error)
  • New function *ClientFactory.NewClient() *Client

Feature Migration removed:

  • New function *ClientFactory.NewRPServiceClient() *RPServiceClient
  • New function NewRPServiceClient(credential azcore.TokenCredential, options *arm.ClientOptions) (*RPServiceClient, error)
  • New function *RPServiceClient.QueryRules(ctx context.Context, privateStoreID string, collectionID string, options *RPServiceClientQueryRulesOptions) (RPServiceClientQueryRulesResponse, error)
  • New function *RPServiceClient.QueryUserRules(ctx context.Context, privateStoreID string, options *RPServiceClientQueryUserRulesOptions) (RPServiceClientQueryUserRulesResponse, error)
  • New function *RPServiceClient.SetCollectionRules(ctx context.Context, privateStoreID string, collectionID string, options *RPServiceClientSetCollectionRulesOptions) (RPServiceClientSetCollectionRulesResponse, error)

- Field `Payload` of struct `PrivateStoreClientUpdateAdminRequestApprovalOptions` has been removed
- Field `Payload` of struct `PrivateStoreCollectionClientCreateOrUpdateOptions` has been removed
- Field `Payload` of struct `PrivateStoreCollectionOfferClientCreateOrUpdateOptions` has been removed

Copy link
Member Author

@jliusan jliusan Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration Breaking Changed added:

  • Function *PrivateStoreClient.CreateApprovalRequest parameter(s) have been changed from (ctx context.Context, privateStoreID string, requestApprovalID string, options *PrivateStoreClientCreateApprovalRequestOptions) to (ctx context.Context, privateStoreID string, requestApprovalID string, payload RequestApprovalResource, options *PrivateStoreClientCreateApprovalRequestOptions)
  • Function *PrivateStoreClient.CreateOrUpdate parameter(s) have been changed from (ctx context.Context, privateStoreID string, options *PrivateStoreClientCreateOrUpdateOptions) to (ctx context.Context, privateStoreID string, payload PrivateStore, options *PrivateStoreClientCreateOrUpdateOptions)
  • Function *PrivateStoreClient.UpdateAdminRequestApproval parameter(s) have been changed from (ctx context.Context, privateStoreID string, adminRequestApprovalID string, options *PrivateStoreClientUpdateAdminRequestApprovalOptions) to (ctx context.Context, privateStoreID string, adminRequestApprovalID string, payload AdminRequestApprovalsResource, options *PrivateStoreClientUpdateAdminRequestApprovalOptions)
  • Type of CollectionsToSubscriptionsMappingResponse.Details has been changed from map[string]*CollectionsSubscriptionsMappingDetails to *CollectionsToSubscriptionsMappingResponseProperties
  • Type of PlanDetails.RequestDate has been changed from any to *time.Time
  • Type of SystemData.CreatedByType has been changed from *IdentityType to *CreatedByType
  • Type of SystemData.LastModifiedByType has been changed from *IdentityType to *CreatedByType
  • Enum IdentityType has been removed
  • Operation *OperationsClient.List has supported pagination, use *OperationsClient.NewListPager instead.
  • Operation *PrivateStoreClient.AdminRequestApprovalsList has supported pagination, use *PrivateStoreClient.NewAdminRequestApprovalsListPager instead.
  • Operation *PrivateStoreClient.GetApprovalRequestsList has supported pagination, use *PrivateStoreClient.NewGetApprovalRequestsListPager instead.
  • Operation *PrivateStoreCollectionClient.List has supported pagination, use *PrivateStoreCollectionClient.NewListPager instead.
  • Struct ErrorResponse has been removed
  • Struct ErrorResponseError has been removed
  • Struct Resource has been removed
  • Field Payload of struct PrivateStoreClientCreateApprovalRequestOptions has been removed
  • Field Payload of struct PrivateStoreClientCreateOrUpdateOptions has been removed
  • Field Payload of struct PrivateStoreClientUpdateAdminRequestApprovalOptions has been removed
  • Field Payload of struct PrivateStoreCollectionClientCreateOrUpdateOptions has been removed
  • Field Payload of struct PrivateStoreCollectionOfferClientCreateOrUpdateOptions has been removed

modifiled breaking changes:
before:

  • Function *PrivateStoreCollectionOfferClient.CreateOrUpdate parameter(s) have been changed from (ctx context.Context, privateStoreID string, offerID string, collectionID string, options *PrivateStoreCollectionOfferClientCreateOrUpdateOptions) to (ctx context.Context, privateStoreID string, collectionID string, offerID string, options *PrivateStoreCollectionOfferClientCreateOrUpdateOptions)

after:

  • Function *PrivateStoreCollectionOfferClient.CreateOrUpdate parameter(s) have been changed from (ctx context.Context, privateStoreID string, offerID string, collectionID string, options *PrivateStoreCollectionOfferClientCreateOrUpdateOptions) to (ctx context.Context, privateStoreID string, collectionID string, offerID string, payload Offer, options *PrivateStoreCollectionOfferClientCreateOrUpdateOptions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants