[Migrate-Mitigation] sdk/resourcemanager/communication/armcommunication #25905
+1,768
−2,096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jliusan
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
jliusan
changed the title
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the armcommunication SDK from AutoRest-generated code to TypeSpec-based generation using the Microsoft Go Code Generator. This is part of a broader SDK modernization effort.
Changes:
- Upgrades from v2.3.0 to v3.0.0 (major version bump)
- Migrates from AutoRest to TypeSpec/Go Code Generator for code generation
- Updates module path from v2 to v3 throughout the codebase
- Removes deprecated files (autorest.md, build.go, time_rfc3339.go)
- Adds TypeSpec configuration (tsp-location.yaml)
- Updates dependencies (azcore 1.20.0 → 1.21.0, golang.org/x/* packages)
- Reformats code with tab alignment in fake server files
- Removes unused model types and simplifies serialization code
Reviewed changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.go | Version bump from v2.3.0 to v3.0.0 |
| tsp-location.yaml | New TypeSpec configuration file for regeneration |
| time_rfc3339.go | Removed (replaced with runtime/datetime) |
| testdata/_metadata.json | New metadata for test recording |
| go.mod | Module path update to v3, dependency updates |
| go.sum | Updated dependency checksums |
| models.go | Removed unused types, updated comments |
| models_serde.go | Simplified serialization using runtime/datetime |
| responses.go | Comment cleanup |
| options.go | Code generator attribution update |
| *_client.go | Updated method comments, added Content-Type headers, removed FinalStateVia |
| *_client_example_test.go | Updated imports to v3, subscription ID changes, response structure updates |
| *_live_test.go | Import path and formatting updates |
| fake/*_server.go | Import path updates, tab alignment for struct fields |
| autorest.md | Removed (no longer needed with TypeSpec) |
| build.go | Removed (replaced with TypeSpec workflow) |
| README.md | Updated installation instructions for v3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generation base on spec branch kazrael2119:communication-convert