-
Notifications
You must be signed in to change notification settings - Fork 957
[Migration-Check]sdk/resourcemanager/purview/armpurview #25862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request migrates the sdk/resourcemanager/purview/armpurview module from AutoRest code generation to TypeSpec-based Go Code Generator. It's a comprehensive update that introduces v2.0.0-beta.1 with new features and breaking changes.
Changes:
- Migrates from AutoRest to TypeSpec/Go Code Generator with updated API version (2024-04-01-preview)
- Introduces new clients (Features, IngestionPrivateEndpointConnections, KafkaConfigurations, Usages)
- Updates module path to v2 with breaking changes to types and enums
Reviewed changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates module path to v2 |
| version.go | New file defining module version v2.0.0-beta.1 |
| tsp-location.yaml | New TypeSpec configuration file |
| CHANGELOG.md | Documents breaking changes and new features for v2 |
| README.md | Updates installation instructions for v2 |
| autorest.md | Removed (no longer using AutoRest) |
| build.go | Removed (build configuration changed) |
| client_factory.go | Refactored factory implementation |
| *_client.go | Updated clients with new API version and TypeSpec patterns |
| models*.go | Updated models with breaking changes and new types |
| fake/* | Updated fake servers with new pattern and interceptor support |
| examples | Updated examples with v2 import paths |
| - Field `Guardian` of struct `AccountPropertiesEndpoints` has been removed | ||
| - Field `Count` of struct `PrivateEndpointConnectionList` has been removed | ||
| - Field `Count` of struct `PrivateLinkResourceList` has been removed | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original 2024-04-01-preview breaking changes:
https://github.com/azure-sdk/azure-sdk-for-go/pull/9691/files

| - Struct `ManagedResources` has been removed | ||
| - Struct `ProxyResource` has been removed | ||
| - Struct `TrackedResource` has been removed | ||
| - Struct `TrackedResourceSystemData` has been removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration Breaking Changes:
- Type of `SystemData.LastModifiedByType` has been changed from `*LastModifiedByType` to `*CreatedByType`
- Type of `Account.SystemData` has been changed from `*TrackedResourceSystemData` to `*SystemData`
- Struct `AccountEndpoints` has been removed
- Struct `AccountSKUAutoGenerated` has been removed
- Struct `ErrorResponseModel` has been removed
- Struct `ErrorResponseModelError` has been removed
- Struct `ManagedResources` has been removed
- Struct `ProxyResource` has been removed
- Struct `TrackedResource` has been removed
- Struct `TrackedResourceSystemData` has been removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TrackedResourceSystemData definition in swagger:
"TrackedResourceSystemData": {
"type": "object",
"description": "Metadata pertaining to creation and last modification of the resource.",
"allOf": [
{
"$ref": "#/definitions/SystemData"
}
]
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CreatedByType and LastModifiedByType definition in swagger:
"LastModifiedByType": {
"type": "string",
"description": "The type of identity that last modified the resource.",
"enum": [
"User",
"Application",
"ManagedIdentity",
"Key"
],
"x-ms-enum": {
"name": "LastModifiedByType",
"modelAsString": true,
"values": [
{
"name": "User",
"value": "User",
"description": "User"
},
{
"name": "Application",
"value": "Application",
"description": "Application"
},
{
"name": "ManagedIdentity",
"value": "ManagedIdentity",
"description": "ManagedIdentity"
},
{
"name": "Key",
"value": "Key",
"description": "Key"
}
]
}
},
"CreatedByType": {
"type": "string",
"description": "The type of identity that created the resource.",
"enum": [
"User",
"Application",
"ManagedIdentity",
"Key"
],
"x-ms-enum": {
"name": "CreatedByType",
"modelAsString": true,
"values": [
{
"name": "User",
"value": "User",
"description": "User"
},
{
"name": "Application",
"value": "Application",
"description": "Application"
},
{
"name": "ManagedIdentity",
"value": "ManagedIdentity",
"description": "ManagedIdentity"
},
{
"name": "Key",
"value": "Key",
"description": "Key"
}
]
}
},
generation on branch welovej:TspMig-purview