Detect new Resource Provider Namespaces, check and validate arm-leases for the RP's #39625
+1,130
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for the new RP's
tejaswiMinnu
requested review from
benbp,
mikeharder and
weshaggard
as code owners
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
tejaswiMinnu
changed the title
raosuhas
reviewed
Jan 13, 2026
| @@ -0,0 +1,73 @@ | |||
| import { existsSync, readFileSync } from 'fs'; | |||
| import { join } from 'path'; | |||
Member
There was a problem hiding this comment.
Is this file just being checked in and not used currently ?
Contributor
Author
There was a problem hiding this comment.
raosuhas
reviewed
Jan 13, 2026
| const SPECIFICATION_PATH = 'specification'; | ||
| // Match pattern: specification/<service>/resource-manager/<ResourceProvider.Namespace>/... | ||
| const RESOURCE_MANAGER_PATTERN = /^specification\/[^\/]+\/resource-manager\/([^\/]+)/; | ||
|
|
Member
There was a problem hiding this comment.
We probably need to consider the folder structure for new service groups as well eventually right ? for example Microsoft.Compute :
Contributor
Author
There was a problem hiding this comment.
Updated code considering service group as optional
raosuhas
reviewed
Jan 13, 2026
| export function checkLease(serviceName, resourceProvider) { | ||
| try { | ||
| const repoRoot = process.env.TEST_REPO_ROOT || execSync('git rev-parse --show-toplevel', { encoding: 'utf-8' }).trim(); | ||
| const leasePath = join(repoRoot, '.github', 'arm-leases', serviceName, resourceProvider, 'lease.yaml'); |
Member
There was a problem hiding this comment.
here again we need to take in servicergoup as optional param. Look at Microsoft.Compute as an example :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The ARM lease validation system makes it easy to check Azure Resource Manager resource provider leases automatically when you open or update a pull request. It helps teams confirm they've got valid leases before making changes to resource providers in the azure-rest-api-specs repo.
Core Components
There are two main modules: detect-arm-leases.js, which handles the lease validation with the checkLease(serviceName, resourceProvider) function, and detect-new-resource-provider.js, which spots new resource provider namespaces and connects with the lease check.
Resource Provider Detection Workflow
Whenever a pull request comes in, the workflow checks for changes in specification/**/resource-manager directories to find new RP namespaces. The extractResourceProviders function gives you a Map of namespace-to-serviceName pairs, which are checked against existing paths with resourceProviderExists. For each new namespace found, checkLease runs and the results are collected and output is designed for consumption by GitHub Actions through the GitHub Script action, enabling automated PR comments that direct contributors to attend office hours for missing or expired leases.
Lease Validation Logic
The checkLease function reads YAML lease files from arm-leases///lease.yaml and checks if the lease is still valid using today <= (startDate + duration). It returns true if the lease is good, or false if it's missing or expired. The system works with different duration formats and handles issues like missing files, invalid YAML, and future start dates without crashing
Just a heads up, this workflow is currently behind a feature flag, so the PMs will decide when and how it gets released.