Redact password patterns from AlertRuleTemplate recording to fix CredScan#29339
Merged
JiaSeng-v merged 4 commits intoAzure:joyer/SecurityInsights-migrate-v4from Mar 31, 2026
Conversation
…ve API issues for AutoRest v4 migration
…m/Azure/azure-powershell into hadas/securityinsights-v4-recordings # Conflicts: # src/SecurityInsights/SecurityInsights.Autorest/docs/Az.SecurityInsights.md # src/SecurityInsights/SecurityInsights.Autorest/generate-info.json # src/SecurityInsights/SecurityInsights.Autorest/test/New-AzSentinelAlertRuleAction.Recording.json # src/SecurityInsights/SecurityInsights.Autorest/test/Update-AzSentinelAlertRuleAction.Recording.json # src/SecurityInsights/SecurityInsights.Autorest/test/deployment-templates/alertRuleAction/template.parameters.json # src/SecurityInsights/SecurityInsights.Autorest/test/env.json # src/SecurityInsights/SecurityInsights.sln # src/SecurityInsights/SecurityInsights/Az.SecurityInsights.psd1
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
|
Thank you for your contribution @hadasi6! We will review the pull request and get back to you soon. |
JiaSeng-v
merged commit 895af88
into
Azure:joyer/SecurityInsights-migrate-v4
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Redacted queries containing password patterns in Get-AzSentinelAlertRuleTemplate.Recording.json to pass CredScan (CSCAN-GENERAL0060) across all 3 Content entries (lines 43, 88, 133).
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.