Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
Updates the Az.AppConfiguration module’s management-plane (RP) surface to use App Configuration API version 2024-06-01, including new replica-related cmdlets and related documentation/test assets.
Changes:
- Updated AutoRest configuration to target the
2024-06-01swagger and added/updated directives. - Added documentation/help/examples/tests for App Configuration replica cmdlets.
- Updated module manifest exports, changelog, solution metadata, and UX API version references.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/AppConfiguration/AppConfiguration/help/Update-AzAppConfigurationStore.md | Updates cmdlet help to reflect new/removed parameters. |
| src/AppConfiguration/AppConfiguration/help/Update-AzAppConfigurationReplica.md | Adds help page for replica update cmdlet. |
| src/AppConfiguration/AppConfiguration/help/Remove-AzAppConfigurationReplica.md | Adds help page for replica removal cmdlet. |
| src/AppConfiguration/AppConfiguration/help/New-AzAppConfigurationStore.md | Updates help to include new store creation parameters. |
| src/AppConfiguration/AppConfiguration/help/New-AzAppConfigurationReplica.md | Adds help page for replica creation cmdlet. |
| src/AppConfiguration/AppConfiguration/help/Get-AzAppConfigurationReplica.md | Adds help page for replica get/list cmdlet. |
| src/AppConfiguration/AppConfiguration/help/Az.AppConfiguration.md | Adds replica cmdlets to the module help index and refreshes descriptions. |
| src/AppConfiguration/AppConfiguration/ChangeLog.md | Adds upcoming release notes for API version upgrade, replicas, and parameter changes. |
| src/AppConfiguration/AppConfiguration/Az.AppConfiguration.psd1 | Updates exported functions and dependency version; includes replica cmdlets in exports. |
| src/AppConfiguration/AppConfiguration.sln | Updates solution project entries/IDs for the generated AppConfiguration project. |
| src/AppConfiguration/AppConfiguration.Autorest/test/Update-AzAppConfigurationReplica.Tests.ps1 | Adds Pester coverage for replica update scenarios. |
| src/AppConfiguration/AppConfiguration.Autorest/test/Remove-AzAppConfigurationReplica.Tests.ps1 | Adds Pester coverage for replica delete scenarios. |
| src/AppConfiguration/AppConfiguration.Autorest/test/New-AzAppConfigurationReplica.Tests.ps1 | Adds Pester coverage for replica create scenarios. |
| src/AppConfiguration/AppConfiguration.Autorest/test/Get-AzAppConfigurationReplica.Tests.ps1 | Adds Pester coverage for replica get/list scenarios. |
| src/AppConfiguration/AppConfiguration.Autorest/generate-info.json | Updates generation metadata identifier. |
| src/AppConfiguration/AppConfiguration.Autorest/examples/Update-AzAppConfigurationReplica.md | Adds example(s) for updating replicas. |
| src/AppConfiguration/AppConfiguration.Autorest/examples/Remove-AzAppConfigurationReplica.md | Adds example(s) for removing replicas. |
| src/AppConfiguration/AppConfiguration.Autorest/examples/New-AzAppConfigurationReplica.md | Adds example(s) for creating replicas. |
| src/AppConfiguration/AppConfiguration.Autorest/examples/Get-AzAppConfigurationReplica.md | Adds example(s) for getting/listing replicas. |
| src/AppConfiguration/AppConfiguration.Autorest/docs/Update-AzAppConfigurationStore.md | Updates reference docs to match updated parameter surface. |
| src/AppConfiguration/AppConfiguration.Autorest/docs/Update-AzAppConfigurationReplica.md | Adds reference doc for replica update cmdlet. |
| src/AppConfiguration/AppConfiguration.Autorest/docs/Remove-AzAppConfigurationReplica.md | Adds reference doc for replica removal cmdlet. |
| src/AppConfiguration/AppConfiguration.Autorest/docs/New-AzAppConfigurationStore.md | Updates reference docs to include new store creation parameters. |
| src/AppConfiguration/AppConfiguration.Autorest/docs/New-AzAppConfigurationReplica.md | Adds reference doc for replica creation cmdlet. |
| src/AppConfiguration/AppConfiguration.Autorest/docs/Get-AzAppConfigurationReplica.md | Adds reference doc for replica get/list cmdlet. |
| src/AppConfiguration/AppConfiguration.Autorest/docs/Az.AppConfiguration.md | Updates Autorest docs index with new replica cmdlets and refreshed descriptions. |
| src/AppConfiguration/AppConfiguration.Autorest/UX/Microsoft.AppConfiguration/locations-deletedConfigurationStores.json | Bumps UX API version to 2024-06-01. |
| src/AppConfiguration/AppConfiguration.Autorest/UX/Microsoft.AppConfiguration/configurationStores.json | Bumps UX API version to 2024-06-01. |
| src/AppConfiguration/AppConfiguration.Autorest/UX/Microsoft.AppConfiguration/configurationStores-replicas.json | Adds UX description for replica resource type using 2024-06-01. |
| src/AppConfiguration/AppConfiguration.Autorest/README.md | Updates spec commit/input-file and adds directives for new API surface. |
| src/AppConfiguration/AppConfiguration.Autorest/Properties/AssemblyInfo.cs | Updates assembly versioning to align with module versioning. |
src/AppConfiguration/AppConfiguration.Autorest/test/Get-AzAppConfigurationReplica.Tests.ps1
Outdated
Show resolved
Hide resolved
| BeforeAll { | ||
| $updateReplicaStoreName = "azupd" + (Get-Random -Maximum 99999) | ||
| New-AzAppConfigurationStore -Name $updateReplicaStoreName -ResourceGroupName $env.resourceGroup -Location $env.location -Sku Standard | ||
| $updateReplicaName = "westus2replica" | ||
| New-AzAppConfigurationReplica -ConfigStoreName $updateReplicaStoreName -ResourceGroupName $env.resourceGroup -Name $updateReplicaName -Location "westus2" | ||
| } |
There was a problem hiding this comment.
This test uses a per-run random store name (Get-Random) and references Update-AzAppConfigurationReplica.Recording.json, but that recording file is not present in the test folder. In playback mode the random name won’t match any recording, and the missing recording file will likely cause the mocking harness to fail. Please switch to deterministic names from env.json (or add new fixed entries) and commit the corresponding .Recording.json for this test.
src/AppConfiguration/AppConfiguration/help/Get-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration/help/Update-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/docs/New-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration/help/New-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration/help/Remove-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/docs/Remove-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/docs/Update-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/test/New-AzAppConfigurationReplica.Tests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/AppConfiguration/AppConfiguration.Autorest/docs/Update-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/docs/New-AzAppConfigurationReplica.md
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/docs/Get-AzAppConfigurationReplica.md
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/docs/Remove-AzAppConfigurationReplica.md
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/docs/Update-AzAppConfigurationStore.md
Show resolved
Hide resolved
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### -DataPlaneProxyAuthenticationMode |
There was a problem hiding this comment.
This PR introduces new store parameters in the public surface area, but the added tests focus on replica cmdlets. Consider adding Pester coverage that exercises these new New-AzAppConfigurationStore / Update-AzAppConfigurationStore parameters (at least acceptance + read-back validation where possible) to prevent regressions in parameter wiring/serialization.
src/AppConfiguration/AppConfiguration/help/New-AzAppConfigurationStore.md
Show resolved
Hide resolved
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### -DefaultKeyValueRevisionRetentionPeriodInSecond |
There was a problem hiding this comment.
This PR introduces new store parameters in the public surface area, but the added tests focus on replica cmdlets. Consider adding Pester coverage that exercises these new New-AzAppConfigurationStore / Update-AzAppConfigurationStore parameters (at least acceptance + read-back validation where possible) to prevent regressions in parameter wiring/serialization.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/AppConfiguration/AppConfiguration/help/Update-AzAppConfigurationStore.md:1
- The help content shows
-EnableSystemAssignedIdentityas<Boolean>, but the generated docs inAppConfiguration.Autorest/docs/Update-AzAppConfigurationStore.mdshow it as nullable (System.Nullable[System.Boolean]). Please align the hand-shipped help undersrc/AppConfiguration/AppConfiguration/help/with the actual cmdlet parameter type (and the generated docs) so users don't get conflicting information about whether the parameter supports an unset/tri-state value.
src/AppConfiguration/AppConfiguration.Autorest/test/Update-AzAppConfigurationReplica.Tests.ps1
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/test/Remove-AzAppConfigurationReplica.Tests.ps1
Show resolved
Hide resolved
| -Location <String> -Sku <String> [-CreateMode <String>] [-DataPlaneProxyAuthenticationMode <String>] | ||
| [-DataPlaneProxyPrivateLinkDelegation <String>] [-DefaultKeyValueRevisionRetentionPeriodInSecond <Int64>] |
There was a problem hiding this comment.
New store parameters (DataPlaneProxyAuthenticationMode, DataPlaneProxyPrivateLinkDelegation, DefaultKeyValueRevisionRetentionPeriodInSecond) are introduced/advertised here, but this PR doesn't include Pester coverage that exercises these parameters (e.g., create/update with the parameters set and verify the resulting store properties). Adding tests for these new parameters would better protect against regressions in the new API version surface.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 37 out of 41 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (2)
src/AppConfiguration/AppConfiguration/help/Update-AzAppConfigurationStore.md:1
- Capitalize the proper service name for consistency and correctness (e.g., 'Azure App Configuration store'). This same phrasing appears in several updated help files in this PR, so aligning the capitalization across them would improve help quality.
src/AppConfiguration/AppConfiguration/help/Update-AzAppConfigurationStore.md:1 Update-AzAppConfigurationStoreshows-EnableSystemAssignedIdentity <Boolean>here, but the regenerated Autorest docs in this PR show a nullable boolean (<Boolean?>). Please regenerate/align the help so the parameter type is consistent across shipped help surfaces (or adjust generation so both reflect the actual cmdlet signature).
src/AppConfiguration/AppConfiguration.Autorest/docs/Remove-AzAppConfigurationReplica.md
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/test/Remove-AzAppConfigurationReplica.Tests.ps1
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/test/Remove-AzAppConfigurationReplica.Tests.ps1
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/test/New-AzAppConfigurationReplica.Tests.ps1
Outdated
Show resolved
Hide resolved
src/AppConfiguration/AppConfiguration.Autorest/test/Get-AzAppConfigurationReplica.Tests.ps1
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
There seems to be a few build issues:
@NoriZC any ideas? @jimmyca15 |
|
/azp run |
| ``` | ||
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. |
There was a problem hiding this comment.
-ResourceGroupName description incorrectly refers to a "container registry". This should describe the resource group that contains the App Configuration store for the replica operations.
| The name of the resource group to which the container registry belongs. | |
| The name of the resource group that contains the App Configuration store. |
| ``` | ||
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. |
There was a problem hiding this comment.
-ResourceGroupName description incorrectly refers to a "container registry". This should describe the resource group that contains the App Configuration store for the replica operations.
| The name of the resource group to which the container registry belongs. | |
| The name of the resource group that contains the App Configuration store. |
| --- | ||
| Module Name: Az.AppConfiguration | ||
| Module Guid: eb7a20d7-4675-4932-b491-c24a29f7519e | ||
| Module Guid: 6017deb0-bdea-4770-ab56-df3ec463176b |
There was a problem hiding this comment.
Module Guid in this documentation front-matter does not match the module manifest GUID (Az.AppConfiguration.psd1 has GUID 3ff16738-381e-4d5a-9d90-c7ef6816f78e). Please update the docs Module Guid to match the manifest so tooling and users see a consistent module identity.
| Module Guid: 6017deb0-bdea-4770-ab56-df3ec463176b | |
| Module Guid: 3ff16738-381e-4d5a-9d90-c7ef6816f78e |
| - Added `Update-AzAppConfigurationReplica` cmdlet | ||
| - Added `Remove-AzAppConfigurationReplica` cmdlet | ||
| * Added `DataPlaneProxyAuthenticationMode`, `DataPlaneProxyPrivateLinkDelegation`, and `DefaultKeyValueRevisionRetentionPeriodInSecond` parameters to `New-AzAppConfigurationStore` and `Update-AzAppConfigurationStore` | ||
| * Removed `SoftDeleteRetentionInDay` parameter from `Update-AzAppConfigurationStore` as it is a create-only property |
There was a problem hiding this comment.
This changelog entry says SoftDeleteRetentionInDay was removed from Update-AzAppConfigurationStore, but the updated help/docs in this PR still show -SoftDeleteRetentionInDay as a supported update parameter. Either remove/hide the parameter in the cmdlet surface (and regenerate docs), or update this release note to reflect the actual change.
| * Removed `SoftDeleteRetentionInDay` parameter from `Update-AzAppConfigurationStore` as it is a create-only property | |
| * Updated `SoftDeleteRetentionInDay` parameter description for `Update-AzAppConfigurationStore` to clarify that it is a create-only property and is ignored during updates; the parameter remains available for backward compatibility |
| ``` | ||
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. |
There was a problem hiding this comment.
-ResourceGroupName description incorrectly refers to a "container registry". This should describe the resource group that contains the App Configuration store for the replica operations.
| The name of the resource group to which the container registry belongs. | |
| The name of the resource group that contains the App Configuration store. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. | ||
| The name of the resource group to which the azure app configuration store belongs. |
There was a problem hiding this comment.
The -ResourceGroupName description uses lowercase "azure" and an inconsistent phrase compared to other help content in this module (which uses "App Configuration store"). Please capitalize and standardize the product name, e.g., "Azure App Configuration store" / "App Configuration store".
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. | ||
| The name of the resource group to which the azure app configuration store belongs. |
There was a problem hiding this comment.
The -ResourceGroupName description uses lowercase "azure" and an inconsistent phrase compared to other help content in this module (which uses "App Configuration store"). Please capitalize and standardize the product name, e.g., "Azure App Configuration store" / "App Configuration store".
| ### -ResourceGroupName | ||
| The name of the resource group to which the azure app configuration store belongs. | ||
|
|
There was a problem hiding this comment.
The -ResourceGroupName description uses lowercase "azure" and an inconsistent phrase compared to other help content in this module (which uses "App Configuration store"). Please capitalize and standardize the product name, e.g., "Azure App Configuration store" / "App Configuration store".
| * Added support for App Configuration store replicas | ||
| - Added `New-AzAppConfigurationReplica` cmdlet | ||
| - Added `Get-AzAppConfigurationReplica` cmdlet | ||
| - Added `Update-AzAppConfigurationReplica` cmdlet |
There was a problem hiding this comment.
The changelog claims Update-AzAppConfigurationReplica was added, but this PR explicitly hides Update operations for replicas in AppConfiguration.Autorest/README.md and the module manifest only exports Get/New/Remove replica cmdlets. Please remove the Update-AzAppConfigurationReplica entry (or add and export the cmdlet if it’s intended to exist).
| - Added `Update-AzAppConfigurationReplica` cmdlet |
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. | ||
| The name of the resource group to which the azure app configuration store belongs. |
There was a problem hiding this comment.
The -ResourceGroupName description uses lowercase "azure" and an inconsistent phrase compared to other help content in this module (which uses "App Configuration store"). Please capitalize and standardize the product name, e.g., "Azure App Configuration store" / "App Configuration store".
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. | ||
| The name of the resource group to which the azure app configuration store belongs. |
There was a problem hiding this comment.
The -ResourceGroupName description uses lowercase "azure" and an inconsistent phrase compared to other help content in this module (which uses "App Configuration store"). Please capitalize and standardize the product name, e.g., "Azure App Configuration store" / "App Configuration store".
| $updateReplicaStoreName = "az" + (RandomString -allChars $false -len 4) | ||
| $env.Add("updateReplicaStoreName", $updateReplicaStoreName) | ||
|
|
There was a problem hiding this comment.
updateReplicaStoreName is added to the test environment but is not referenced by any tests in this PR. Please remove it (and the corresponding env.json entry) or add the missing test coverage that uses it.
| $updateReplicaStoreName = "az" + (RandomString -allChars $false -len 4) | |
| $env.Add("updateReplicaStoreName", $updateReplicaStoreName) |
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. | ||
| The name of the resource group to which the azure app configuration store belongs. |
There was a problem hiding this comment.
The -ResourceGroupName description uses lowercase "azure" and an inconsistent phrase compared to other help content in this module (which uses "App Configuration store"). Please capitalize and standardize the product name, e.g., "Azure App Configuration store" / "App Configuration store".
|
|
||
| ### -ResourceGroupName | ||
| The name of the resource group to which the container registry belongs. | ||
| The name of the resource group to which the azure app configuration store belongs. |
There was a problem hiding this comment.
The -ResourceGroupName description uses lowercase "azure" and an inconsistent phrase compared to other help content in this module (which uses "App Configuration store"). Please capitalize and standardize the product name, e.g., "Azure App Configuration store" / "App Configuration store".
| "replicaTestStoreName": "az9akx", | ||
| "Tenant": "00000000-0000-0000-0000-000000000000", | ||
| "newReplicaStoreName": "azklpr", | ||
| "updateReplicaStoreName": "azgnz0", |
There was a problem hiding this comment.
updateReplicaStoreName is present in env.json but no tests reference it in this PR. Please remove unused entries to keep playback env files minimal and avoid confusion.
| "updateReplicaStoreName": "azgnz0", |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| * Added `DataPlaneProxyAuthenticationMode`, `DataPlaneProxyPrivateLinkDelegation`, and `DefaultKeyValueRevisionRetentionPeriodInSecond` parameters to `New-AzAppConfigurationStore` and `Update-AzAppConfigurationStore` | ||
| * Removed `SoftDeleteRetentionInDay` parameter from `Update-AzAppConfigurationStore` as it is a create-only property |
There was a problem hiding this comment.
The changelog claims SoftDeleteRetentionInDay was removed from Update-AzAppConfigurationStore, but the updated help/docs (and generated cmdlet) still expose -SoftDeleteRetentionInDay. Please either actually hide/remove this parameter in generation (and regenerate help), or update the changelog entry to reflect the real surface area change.
| # Strip x-ms-identifiers extension to avoid schema validation errors | ||
| - from: swagger-document | ||
| where: $.definitions.OperationDefinitionListResult.properties.value | ||
| transform: delete $['x-ms-identifiers'] | ||
| - from: swagger-document | ||
| where: $.definitions.ServiceSpecification.properties.logSpecifications | ||
| transform: delete $['x-ms-identifiers'] | ||
| - from: swagger-document | ||
| where: $.definitions.ServiceSpecification.properties.metricSpecifications | ||
| transform: delete $['x-ms-identifiers'] | ||
| - from: swagger-document | ||
| where: $.definitions.MetricSpecification.properties.dimensions | ||
| transform: delete $['x-ms-identifiers'] | ||
| - from: swagger-document | ||
| where: $.definitions.ErrorDetails.properties.additionalInfo | ||
| transform: delete $['x-ms-identifiers'] |
There was a problem hiding this comment.
AutoRest README directives should be individually commented with the rationale (“why”) for each transformation. The newly added swagger-document transforms (multiple delete $['x-ms-identifiers']) currently share a single header comment; please add per-directive comments (or otherwise clearly document each directive’s purpose/target) to match the repository’s AutoRest README guidance.
| # Strip x-ms-identifiers extension to avoid schema validation errors | |
| - from: swagger-document | |
| where: $.definitions.OperationDefinitionListResult.properties.value | |
| transform: delete $['x-ms-identifiers'] | |
| - from: swagger-document | |
| where: $.definitions.ServiceSpecification.properties.logSpecifications | |
| transform: delete $['x-ms-identifiers'] | |
| - from: swagger-document | |
| where: $.definitions.ServiceSpecification.properties.metricSpecifications | |
| transform: delete $['x-ms-identifiers'] | |
| - from: swagger-document | |
| where: $.definitions.MetricSpecification.properties.dimensions | |
| transform: delete $['x-ms-identifiers'] | |
| - from: swagger-document | |
| where: $.definitions.ErrorDetails.properties.additionalInfo | |
| transform: delete $['x-ms-identifiers'] | |
| # Strip x-ms-identifiers extension to avoid schema validation errors | |
| # Remove x-ms-identifiers from operation list items to keep the collection schema compatible with AutoRest/PowerShell generation | |
| - from: swagger-document | |
| where: $.definitions.OperationDefinitionListResult.properties.value | |
| transform: delete $['x-ms-identifiers'] | |
| # Remove x-ms-identifiers from logSpecifications to avoid validation issues on the service diagnostics definition | |
| - from: swagger-document | |
| where: $.definitions.ServiceSpecification.properties.logSpecifications | |
| transform: delete $['x-ms-identifiers'] | |
| # Remove x-ms-identifiers from metricSpecifications to prevent schema extension conflicts in metrics metadata | |
| - from: swagger-document | |
| where: $.definitions.ServiceSpecification.properties.metricSpecifications | |
| transform: delete $['x-ms-identifiers'] | |
| # Remove x-ms-identifiers from metric dimensions so the dimensions array schema passes AutoRest validation | |
| - from: swagger-document | |
| where: $.definitions.MetricSpecification.properties.dimensions | |
| transform: delete $['x-ms-identifiers'] | |
| # Remove x-ms-identifiers from error additionalInfo entries to avoid validation issues on extended error payloads | |
| - from: swagger-document | |
| where: $.definitions.ErrorDetails.properties.additionalInfo | |
| transform: delete $['x-ms-identifiers'] | |
| # Remove x-ms-identifiers from snapshot filters so the filters collection schema is compatible with the generator |
| if ($content -ne $sanitized) { | ||
| Set-Content $_.FullName $sanitized -NoNewline | ||
| } |
There was a problem hiding this comment.
When rewriting recording files, Set-Content without an explicit -Encoding can produce different encodings across PowerShell editions (e.g., UTF-16 in Windows PowerShell vs UTF-8 in pwsh). Please specify a stable encoding (typically UTF-8) when writing the sanitized recording content to avoid noisy diffs and potential tooling issues.
| -replace '(?<=\\"connectionString\\":\\")(Endpoint=https://[^"\\]+)(?=\\")', 'Endpoint=https://sanitized.azconfig.io;Id=XXXX;Secret=SANITIZED' ` | ||
| -replace '(?<=\\"value\\":\\")[A-Za-z0-9+/]{20,}=*(?=\\")', 'SANITIZED' | ||
| if ($content -ne $sanitized) { | ||
| Set-Content $TestRecordingFile $sanitized -NoNewline |
There was a problem hiding this comment.
Same as in utils.ps1: Set-Content is used to rewrite the recording file without specifying -Encoding, which can vary by PowerShell edition and cause inconsistent file encodings. Please write the sanitized recording content with an explicit UTF-8 encoding to keep recordings stable.
| Set-Content $TestRecordingFile $sanitized -NoNewline | |
| Set-Content $TestRecordingFile $sanitized -Encoding utf8 -NoNewline |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Updates the Azure App Configuration RP module to the latest released version of 2024-06-01
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.