Skip to content

Logging environment value of LocalSitePackagesPath in RunFromPackageHandler #11541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surgupta-msft wants to merge 7 commits into
base: dev
Choose a base branch
from
+12 −8
Open

Logging environment value of LocalSitePackagesPath in RunFromPackageHandler #11541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b956ad2
Adding log
surgupta-msft Jan 2, 2026
192f873
Minor change
surgupta-msft Jan 2, 2026
e383123
Updated log line
surgupta-msft Jan 5, 2026
7d5873d
Update src/WebJobs.Script.WebHost/Management/LinuxSpecialization/RunF…
surgupta-msft Jan 5, 2026
88e09d7
Fix tests and address feedback
surgupta-msft Jan 6, 2026
ccb67dc
Resolved merge conflic
surgupta-msft Jan 6, 2026
88e8798
Updating release notes
surgupta-msft Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
-->
- Add JitTrace Files for v4.1046
- Update Java Worker Version to [2.19.4](https://github.com/Azure/azure-functions-java-worker/releases/tag/2.19.4)
- Logging environment value of LocalSitePackagesPath in RunFromPackageHandler (#11541)
11 changes: 6 additions & 5 deletions src/WebJobs.Script.WebHost/Management/LinuxSpecialization/RunFromPackageHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) .NET Foundation. All rights reserved.
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.

using System;
Expand Down Expand Up @@ -49,10 +49,11 @@ public async Task<bool> ApplyRunFromPackageContext(RunFromPackageContext pkgCont
// So extracting to /home/site/wwwroot can interfere with other running instances
// Instead extract to localSitePackagesPath and bind to /home/site/wwwroot
// home will continue to point to azure file share
var localSitePackagesPath = azureFilesMounted
? _environment.GetEnvironmentVariableOrDefault(EnvironmentSettingNames.LocalSitePackages,
EnvironmentSettingNames.DefaultLocalSitePackagesPath)
: string.Empty;
var localSitePackagesEnvValue = _environment.GetEnvironmentVariable(EnvironmentSettingNames.LocalSitePackages);
var resolvedLocalSitePackagesPath = localSitePackagesEnvValue ?? EnvironmentSettingNames.DefaultLocalSitePackagesPath;
_logger.LogDebug("Environment variable '{LocalSitePackagesEnvVarName}' value: '{LocalSitePackagesEnvValue}'. Resolved path: '{ResolvedLocalSitePackagesPath}'", EnvironmentSettingNames.LocalSitePackages, localSitePackagesEnvValue, resolvedLocalSitePackagesPath);

var localSitePackagesPath = azureFilesMounted ? resolvedLocalSitePackagesPath : string.Empty;

// download zip
string filePath = await _packageDownloadHandler.Download(pkgContext);
Expand Down
8 changes: 5 additions & 3 deletions test/WebJobs.Script.Tests.Integration/Management/InstanceManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) .NET Foundation. All rights reserved.
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.

using System;
Expand Down Expand Up @@ -222,12 +222,13 @@ public async Task StartAssignment_Succeeds_With_NonEmpty_ScmRunFromPackage_Blob(

var logs = _loggerProvider.GetAllLogMessages().Select(p => p.FormattedMessage).ToArray();

if (logs.Length == 10)
if (logs.Length == 11)
{
Assert.Collection(logs,
p => Assert.StartsWith("Starting Assignment", p),
p => Assert.StartsWith("Applying 1 app setting(s)", p),
p => Assert.EndsWith("points to an existing blob: True", p),
p => Assert.StartsWith("Environment variable 'LocalSitePackagesPath'", p),
p => Assert.StartsWith("Unsquashing remote zip", p),
p => Assert.StartsWith("Running: ", p),
p => Assert.StartsWith("Output:", p),
Expand Down Expand Up @@ -1606,12 +1607,13 @@ public async Task AssignInstanceAsync_Succeeds_With_NonEmpty_ScmRunFromPackage_B

var logs = _loggerProvider.GetAllLogMessages().Select(p => p.FormattedMessage).ToArray();

if (logs.Length == 10)
if (logs.Length == 11)
{
Assert.Collection(logs,
p => Assert.StartsWith("Starting Assignment", p),
p => Assert.StartsWith("Applying 1 app setting(s)", p),
p => Assert.EndsWith("points to an existing blob: True", p),
p => Assert.StartsWith("Environment variable 'LocalSitePackagesPath'", p),
p => Assert.StartsWith("Unsquashing remote zip", p),
p => Assert.StartsWith("Running: ", p),
p => Assert.StartsWith("Output:", p),
Expand Down