Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Jan 22, 2026

Issue describing the changes in this PR

resolves #3304

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This PR ports the AssignFunctionsBaseImage from the existing SDK to the new MSBuild SDK.

Copilot AI review requested due to automatic review settings January 22, 2026 22:31
@jviau jviau changed the title Add initial func publish targets [MSBUILD SDK] Add initial func container publish targets Jan 22, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ports the AssignFunctionsBaseImage target from the existing SDK to the new MSBuild SDK, enabling container publish functionality for Azure Functions. The target configures container base images, working directory, runtime identifier, and environment variables for containerized deployments.

Changes:

  • Added new publish targets file with AssignFunctionsBaseImage target for container configuration
  • Imported the new publish targets into the main SDK targets file
  • Updated .gitignore to allow the new Publish directory while keeping the general publish/ exclusion

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/Azure.Functions.Sdk/Targets/Publish/Azure.Functions.Sdk.Publish.targets New file defining container base image assignment and configuration for Azure Functions containerization
src/Azure.Functions.Sdk/Targets/Azure.Functions.Sdk.targets Imports the new publish targets file to integrate container publish functionality
.gitignore Adds exception to allow the new Publish targets directory despite general publish/ exclusion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jviau jviau force-pushed the jviau/msbuild-sdk/publish branch from 97863a0 to 044b364 Compare January 22, 2026 23:09
@jviau jviau force-pushed the jviau/msbuild-sdk/publish branch from a6ab603 to 3bce58c Compare January 23, 2026 18:52
@jviau jviau merged commit b55e0d5 into feature/msbuild-sdk Jan 23, 2026
28 checks passed
@jviau jviau deleted the jviau/msbuild-sdk/publish branch January 23, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants