Skip to content

{Packaging} Only install pymsalruntime on Windows #31617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Jun 10, 2025
Merged

{Packaging} Only install pymsalruntime on Windows #31617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/azure-cli-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
'knack~=0.11.0',
'microsoft-security-utilities-secret-masker~=1.0.0b4',
'msal-extensions==1.2.0',
'msal[broker]==1.33.0b1',
'msal[broker]==1.33.0b1; sys_platform == "win32"',
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider defining the MSAL version in a single variable (e.g. msal_version = '1.33.0b1') to avoid duplicating the version string across multiple dependency lines: this makes future updates less error-prone.

Copilot uses AI. Check for mistakes.
'msal==1.33.0b1; sys_platform != "win32"',
Comment on lines +57 to +58
Copy link
Member Author

@jiasli jiasli Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSAL uses platform_system:

https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/d49296c1b2a929a6ab11380e237daa89a5298512/setup.cfg#L69

    pymsalruntime>=0.18,<0.19; python_version>='3.8' and platform_system=='Linux'

but I prefer using sys_platform which Azure CLI has be using for a long time:

azure-cli/src/azure-cli-core/setup.py

Line 51 in 9071ce0

'distro; sys_platform == "linux"',

azure-cli/src/azure-cli-core/setup.py

Line 62 in 9071ce0

'psutil>=5.9; sys_platform != "cygwin"',

'msrestazure~=0.6.4',
'packaging>=20.9',
'pkginfo>=1.5.0.1',
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Darwin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jmespath==0.9.5
jsondiff==2.0.0
knack==0.11.0
msal-extensions==1.2.0
msal[broker]==1.33.0b1
msal==1.33.0b1
msrest==0.7.1
msrestazure==0.6.4
oauthlib==3.2.2
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jmespath==0.9.5
jsondiff==2.0.0
knack==0.11.0
msal-extensions==1.2.0
msal[broker]==1.33.0b1
msal==1.33.0b1
msrest==0.7.1
msrestazure==0.6.4
oauthlib==3.2.2
Expand Down
Loading