[Containerapp] Fix #29711: az containerapp logs show: Fix JSON escaping by default or with --format json
#29767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2024 16:37
️✔️AzureCLI-FullTest
|
|
Hi @Greedygre, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Containerapp |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
Juliehzl
approved these changes
Aug 22, 2024
yanzhudd
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp logs showFix issue: #29711
Description
For
jsonformat in log, characters in json need to be escaped.For example
"in logs, it should be\". Currently it is not escaped correctly.For example, this is not a valid json:
{"TimeStamp": "2024-08-22T08:37:19.1646828Z", "Log": "INFO:root:UTC time: 2024-08-22 08:37:18.326665+00:00, IST time 2024-08-22 14:07:18.326665+05:30, count: 4817, DEBUG [16:46:37] - urllib3.connectionpool (connectionpool _make_request 546) - https://kv-baz.azure.net:443 "GET /secrets/foobar/?api-version=7.5 HTTP/11" 401 97"}After fix:
{"TimeStamp": "2024-08-22T08:37:19.1646828Z", "Log": "INFO:root:UTC time: 2024-08-22 08:37:18.326665+00:00, IST time 2024-08-22 14:07:18.326665+05:30, count: 4817, DEBUG [16:46:37] - urllib3.connectionpool (connectionpool _make_request 546) - https://kv-baz.azure.net:443 \"GET /secrets/foobar/?api-version=7.5 HTTP/11\" 401 97"}If --format text, the log is:
INFO:root:UTC time: 2024-08-22 08:46:58.845724+00:00, IST time 2024-08-22 14:16:58.845724+05:30, count: 4875, DEBUG [16:46:37] - urllib3.connectionpool (connectionpool _make_request 546) - https://kv-baz.azure.net:443 "GET /secrets/foobar/?api-version=7.5 HTTP/11" 401 97Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.