{AppConfig} az appconfig: Update azure appconfiguration sdk to version 1.7.0
#29749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertofori
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @albertofori, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
AppConfig |
microsoft-github-policy-service
bot
requested review from
avanigupta and
yonzhan
microsoft-github-policy-service
bot
added
App Configuration
Auto-Assign
Contributor
|
@albertofori Please resolve these conflicts~ |
zhoxing-ms
reviewed
Sep 23, 2024
| parse_key_vault_id(source_id=secret_identifier) | ||
| kv = KeyValue(key=key, | ||
| value=json.dumps({"uri": secret_identifier}, ensure_ascii=False, separators=(',', ':')), | ||
| value=json.dumps({"uri": secret_identifier}, ensure_ascii=False), |
Contributor
There was a problem hiding this comment.
May I ask if these separators changes will lead to a breaking change for customer automation scripts?
Member
Author
There was a problem hiding this comment.
This change should not affect user automation scripts. The initial separators were added to remove whitespaces after the "," and ":" in a JSON serialized string. This removal of whitespace is not needed anymore and will not break any customer scenarios since the contents of the strings will still remain, and be used or written as parsed JSON values.
Contributor
|
Please note that we are launching the release for this sprint this week. Please resolve all comments and CI issues by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 11-05) |
zhoxing-ms
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az appconfigDescription
This change update the azure-appconfiguration package to the latest stable version.
Testing Guide
History Notes
{AppConfig}
az appconfig: Update azure appconfiguration sdk to version 1.7.0This checklist is used to make sure that common guidelines for a pull request are followed.
[ x ] The PR title and description has followed the guideline in Submitting Pull Requests.
[ x ] I adhere to the Command Guidelines.
[ x ] I adhere to the Error Handling Guidelines.