[Monitor] az monitor action-group create: Adjust formatting of --actions help message
#29747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you concatenate a regular string with a multi-line string using the + operator, the multi-line string loses its formatting and is treated as a single line. To preserve the formatting of the multi-line string, you should use a different approach. I've updated these to include the entire text within triple quotes without concatenation.
quillanogle
requested review from
AllyW,
jsntcy,
kairu-ms and
necusjz
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @quillanogle, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
quillanogle
changed the title
quillanogle
changed the title
rerun checks
Contributor
Author
|
#sign-off |
quillanogle
changed the title
quillanogle
changed the title
quillanogle
changed the title
az monitor action-group create: Change --actions
AllyW
reviewed
Aug 28, 2024
src/azure-cli/azure/cli/command_modules/monitor/operations/action_groups.py
Show resolved
Hide resolved
AllyW
reviewed
Sep 20, 2024
src/azure-cli/azure/cli/command_modules/monitor/operations/action_groups.py
Show resolved
Hide resolved
fixed line 361
quillanogle
commented
Sep 20, 2024
Contributor
Author
quillanogle
left a comment
quillanogle
left a comment
There was a problem hiding this comment.
fixed line 361
src/azure-cli/azure/cli/command_modules/monitor/operations/action_groups.py
Show resolved
Hide resolved
Contributor
Author
|
#sign-off |
Collaborator
|
Please fix CI issues |
Contributor
Author
|
AllyW
changed the title
az monitor action-group create: Change --actionsaz monitor action-group create: Fix formatting of --actions helping message
AllyW
changed the title
az monitor action-group create: Fix formatting of --actions helping message az monitor action-group create: Fix formatting of --actions help message
AllyW
changed the title
az monitor action-group create: Fix formatting of --actions help message az monitor action-group create: Adjust formatting of --actions help message
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
AllyW
approved these changes
Sep 23, 2024
juliusl
pushed a commit
to juliusl/azure-cli
that referenced
this pull request
Sep 23, 2024
…ctions` help message (Azure#29747) * Update action_groups.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you concatenate a regular string with a multi-line string using the + operator, the multi-line string loses its formatting and is treated as a single line.
To preserve the formatting of the multi-line string, you should use a different approach.
I've updated these to include the entire text within triple quotes without concatenation.
Related command
az monitor action-group create
az monitor action-group update
az monitor action-group notification create
Description
There were multi line strings for the additional data for these command parameters that were broken and just showed large blocks of text.
Testing Guide
just the help notes for the create and update commands.
History Notes
[Monitor]
az monitor action-group create: Adjust formatting of--actionshelp message[Monitor]
az monitor action-group update: Adjust formatting of--add-actionshelp message[Monitor]
az monitor action-group notification create: Adjust formatting of--add-actionshelp messageThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.