[Containerapp] az containerapp env create: Deprecate unused argument --docker-bridge-cidr
#29746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @Greedygre, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env create | cmd containerapp env create update parameter docker_bridge_cidr: added property deprecate_info_hide=True |
||
| containerapp env create | cmd containerapp env create update parameter docker_bridge_cidr: added property deprecate_info_target=--docker-bridge-cidr |
Collaborator
|
Containerapp |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
Greedygre
changed the title
az containerapp env create: Remove not used argument --docker-bridge-cidraz containerapp env create: Remove unused argument --docker-bridge-cidr
Juliehzl
approved these changes
Aug 20, 2024
LaylaLiu-gmail
approved these changes
Aug 20, 2024
Greedygre
changed the title
az containerapp env create: Remove unused argument --docker-bridge-cidraz containerapp env create: Deprecate unused argument --docker-bridge-cidr
Contributor
|
please rerun relative tests to verify this PR won't bring any unexpected change. |
Contributor
Author
Hi @yanzhudd Rerun relative tests and add one test for the deprecated argument. |
Juliehzl
reviewed
Aug 21, 2024
src/azure-cli/azure/cli/command_modules/containerapp/_params.py
Outdated
Show resolved
Hide resolved
Juliehzl
approved these changes
Aug 21, 2024
yanzhudd
previously approved these changes
Aug 21, 2024
3 tasks
yanzhudd
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Option '--docker-bridge-cidr' has been deprecated and will be removed in a future release.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.