[Containerapp] az containerapp registry set: Throw ValidationError if --identity input value is invalid
#29738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @Greedygre, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Containerapp |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007,
yanzhudd and
zhoxing-ms
Greedygre
changed the title
az containerapp registry set: validate --identity, throw ValidationError if input value is invalidaz containerapp registry set: Validate --identity, throw ValidationError if input value is invalid
Greedygre
changed the title
az containerapp registry set: Validate --identity, throw ValidationError if input value is invalidaz containerapp registry set: Throw ValidationError if --identity input value is invalid
njuCZ
approved these changes
Aug 20, 2024
Juliehzl
reviewed
Aug 20, 2024
| _validate_subscription_registered(cmd, CONTAINER_APPS_RP) | ||
| if (username or password) and identity: | ||
| raise MutuallyExclusiveArgumentError("Use either identity or username/password.") | ||
| if identity and identity.lower() != "system" and not is_valid_resource_id(identity): |
Contributor
Author
There was a problem hiding this comment.
Currently the response from request is :
The following field(s) are either invalid or missing. Field 'configuration.Registries<acr>.azurecr.io.Identity' is invalid with details: 'Invalid value: "mic-acr-puller": Managed Identity does not exist';..
I think we can add validation in CLI.
Contributor
Author
|
Will fix in RP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp registry setDescription
Fix issue: microsoft/azure-container-apps#1233
Give a friendly error message when --identity input value is invalid
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.