[AKS] az aks create/update: Update the VM SKU regex validation to include larger set of VMs for Azure Container Storage
#29726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukhoakash
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
AKS |
microsoft-github-policy-service
bot
requested review from
FumingZhang,
calvinhzy,
evelyn-ys and
yonzhan
FumingZhang
reviewed
Aug 22, 2024
| def get_cores_from_sku(vm_size): | ||
| cpu_value = -1 | ||
| pattern = r'standard_([a-z]+)(\d+)([a-z]*)_v(\d+)' | ||
| pattern = r'standard_([a-z]+)(\d+)([a-z]*)(?:_[^_]+)*_v(\d+)' |
Member
There was a problem hiding this comment.
Could you please add some unit test for the change?
Contributor
|
Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 10-08) |
zhoxing-ms
modified the milestones:
August 2024 (2024-09-03),
September 2024 (2024-10-08)
mukhoakash
force-pushed
the
mukhoakash/update_acstor_regex
branch
from
4c16f1a to
66622de
Compare
Contributor
Author
|
@FumingZhang @zhoxing-ms All the comments are resolved and CIs are fixed. Please review and sign off for the current milestone. Thank you |
yanzhudd
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.