Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/network/_help.py
Original file line number Diff line number Diff line change
Expand Up @@ -4182,7 +4182,7 @@
type: command
short-summary: Add an address pool to an IP configuration.
examples:
- name: Add an address pool to an IP configuration.
- name: Add an address pool to an IP configuration. Specify the full backend pool ID of a load balancer when in a different resource group than the specified NIC.
text: |
az network nic ip-config address-pool add -g MyResourceGroup --nic-name MyNic \\
-n MyIpConfig --address-pool MyAddressPool
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

@register_command_group(
"network lb address-pool address",
is_preview=True,
)
class __CMDGroup(AAZCommandGroup):
"""Manage backend addresses of the cross-region load balance backend address pool.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

@register_command(
"network lb address-pool address add",
is_preview=True,
)
class Add(AAZCommand):
"""Add one backend address into the load balance backend address pool.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

@register_command(
"network lb address-pool address list",
is_preview=True,
)
class List(AAZCommand):
"""List all backend addresses of the load balance backend address pool.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

@register_command(
"network lb address-pool address remove",
is_preview=True,
)
class Remove(AAZCommand):
"""Remove one backend address from the load balance backend address pool.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

@register_command(
"network lb address-pool address show",
is_preview=True,
)
class Show(AAZCommand):
"""Show the backend address from the load balance backend address pool.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

@register_command(
"network lb address-pool address update",
is_preview=True,
)
class Update(AAZCommand):
"""Update the backend address into the load balance backend address pool.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ def _build_arguments_schema(cls, *args, **kwargs):
options=["--probe-threshold"],
arg_group="Properties",
help={"short-summary": "The number of consecutive successful or failed probes in order to allow or deny traffic from being delivered to this endpoint. It is currently in preview and is not recommended for production workloads. For most scenarios, we recommend maintaining the default value of 1 by not specifying the value of the property.", "long-summary": "After failing the number of consecutive probes equal to this value, the endpoint will be taken out of rotation and require the same number of successful consecutive probes to be placed back in rotation."},
is_preview=True,
)
_args_schema.protocol = AAZStrArg(
options=["--protocol"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ def _build_arguments_schema(cls, *args, **kwargs):
options=["--probe-threshold"],
arg_group="Properties",
help={"short-summary": "The number of consecutive successful or failed probes in order to allow or deny traffic from being delivered to this endpoint. It is currently in preview and is not recommended for production workloads. For most scenarios, we recommend maintaining the default value of 1 by not specifying the value of the property.", "long-summary": "After failing the number of consecutive probes equal to this value, the endpoint will be taken out of rotation and require the same number of successful consecutive probes to be placed back in rotation."},
is_preview=True,
nullable=True,
)
_args_schema.protocol = AAZStrArg(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -728,11 +728,12 @@ def _build_arguments_schema(cls, *args, **kwargs):

def pre_operations(self):
args = self.ctx.args
if has_value(args.probe_threshold):
if has_value(args.number_of_probes):
logger.warning(
"Please note that the parameter --probe-threshold is currently in preview and is not recommended "
"for production workloads. For most scenarios, we recommend maintaining the default value of 1 "
"by not specifying the value of the property."
"The property \"numberOfProbes\" is not respected. Load Balancer health probes will probe up or down "
"immediately after one probe regardless of the property's configured value. To control the number of "
"successful or failed consecutive probes necessary to mark backend instances as healthy or unhealthy, "
"please leverage the property \"probeThreshold\" instead."
)
if has_value(args.request_path) and args.request_path == "":
args.request_path = None
Expand All @@ -750,11 +751,12 @@ def _build_arguments_schema(cls, *args, **kwargs):

def pre_operations(self):
args = self.ctx.args
if has_value(args.probe_threshold):
if has_value(args.number_of_probes):
logger.warning(
"Please note that the parameter --probe-threshold is currently in preview and is not recommended "
"for production workloads. For most scenarios, we recommend maintaining the default value of 1 "
"by not specifying the value of the property."
"The property \"numberOfProbes\" is not respected. Load Balancer health probes will probe up or down "
"immediately after one probe regardless of the property's configured value. To control the number of "
"successful or failed consecutive probes necessary to mark backend instances as healthy or unhealthy, "
"please leverage the property \"probeThreshold\" instead."
)
if has_value(args.request_path) and args.request_path == "":
args.request_path = None
Expand Down