[AKS] az aks create/update: Support in place param updates for managed prom
#29273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bragi92
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @bragi92, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
AKS |
microsoft-github-policy-service
bot
requested review from
FumingZhang and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
bragi92
commented
Jun 28, 2024
src/azure-cli/azure/cli/command_modules/acs/azuremonitormetrics/azuremonitorprofile.py
Show resolved
Hide resolved
FumingZhang
reviewed
Jun 28, 2024
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
lgtm
Queued live test to validate the change.
- test_aks_create_with_azuremonitormetrics
- test_aks_update_with_azuremonitormetrics
Member
Author
|
@FumingZhang I had to push in a styling fix. Queued live test again. Can you also help with re-running the PR checks? It looks like its failing for an unrelated reason. |
bragi92
changed the title
az aks create/update: support in place param updates for managed promaz aks create/update: Support in place param updates for managed prom
Member
|
Hey @bragi92, I don't have the permission either, will ping cli team member to help take a look |
yanzhudd
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks update -n kaveeshcli22 -g kaveeshcli --enable-azure-monitor-metrics --ksm-metric-labels-allow-list "namespaces=[k8s-label-1,k8s-label-n]" --ksm-metric-annotations-allow-list "pods=[k8s-annotation-1,k8s-annotation-n]"Description
Updating the behavior of the az aks update command for managed prom to accept KSM parameter updates even when the addon is enabled on the cluster and stopping the error we throw saying that you have to disable the addon first before updating.
Testing Guide
Have the Azure Managed Prometheus enabled on a cluster.
Now run :
az aks update -n kaveeshcli22 -g kaveeshcli --enable-azure-monitor-metrics --ksm-metric-labels-allow-list "namespaces=[k8s-label-1,k8s-label-n]" --ksm-metric-annotations-allow-list "pods=[k8s-annotation-1,k8s-annotation-n]"The command should give an output which contains the following based on the parameters you passed in:
"azureMonitorProfile": {
"metrics": {
"enabled": true,
"kubeStateMetrics": {
"metricAnnotationsAllowList": "pods=[k8s-annotation-1,k8s-annotation-n]",
"metricLabelsAllowlist": "namespaces=[k8s-label-1,k8s-label-n]"
}
}
},
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.