{Core} Credential handler with 1es sdk #28590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
requested review from
calvinhzy,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @evelyn-ys, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Core |
microsoft-github-policy-service
bot
added
Auto-Assign
yonzhan
modified the milestones:
April 2024 (2024-04-30),
May 2024 (2024-05-21)❗ Breaking change release ❗
yonzhan
modified the milestones:
May 2024 (2024-05-21)❗ Breaking change release ❗,
June 2024 (2024-07-02)
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
evelyn-ys
modified the milestones:
August 2024 (2024-09-03),
September 2024 (2024-10-08)
calvinhzy
previously approved these changes
Sep 23, 2024
calvinhzy
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
We used to define credential patterns by ourselves. Since microsoft-security-utilities-secret-masker SDK has been released and it supports different confidence levels for secret rules, it's time to switch to this SDK instead of using hard-coded pattern rules in cli core.
This PR leverages High Confidence Level patterns from
microsoft-security-secret-maskerby default to reduce false positives as much as possibleTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.