Skip to content

Conversation

@nafizhaider32
Copy link
Contributor

@nafizhaider32 nafizhaider32 commented Jan 27, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 27, 2026 20:06
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 27, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 27, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the AOSM extension to fix unauthorized errors when publishing to Azure Container Registry (ACR) via az aosm nsd publish, and bumps the extension version accordingly.

Changes:

  • Bump the AOSM extension version from 2.0.0b3 to 2.0.0b4 and document the new release in HISTORY.rst.
  • Update AzureContainerRegistry.copy_image_to_target_acr to obtain an ACR-scoped access token and pass additional parameters into az acr import to address 401/Unauthorized issues.
  • Introduce private helper methods for retrieving the current subscription ID and the source ACR’s resource group (not yet used in the main flow).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/aosm/setup.py Bumps the extension version to 2.0.0b4 to match the new release containing the ACR authorization fix.
src/aosm/azext_aosm/common/registry.py Adjusts the ACR import logic to use an ACR-specific OAuth scope and additional parameters, and adds helper methods for subscription and resource group lookup.
src/aosm/HISTORY.rst Adds a 2.0.0b4 changelog entry describing the fix for unauthorized errors when publishing to ACR.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AOSM Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants