-
Notifications
You must be signed in to change notification settings - Fork 1.5k
AOSM CLI- Fix UnAuthorized Action with az aosm nsd publish #9553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the AOSM extension to fix unauthorized errors when publishing to Azure Container Registry (ACR) via az aosm nsd publish, and bumps the extension version accordingly.
Changes:
- Bump the AOSM extension version from
2.0.0b3to2.0.0b4and document the new release inHISTORY.rst. - Update
AzureContainerRegistry.copy_image_to_target_acrto obtain an ACR-scoped access token and pass additional parameters intoaz acr importto address 401/Unauthorized issues. - Introduce private helper methods for retrieving the current subscription ID and the source ACR’s resource group (not yet used in the main flow).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/aosm/setup.py | Bumps the extension version to 2.0.0b4 to match the new release containing the ACR authorization fix. |
| src/aosm/azext_aosm/common/registry.py | Adjusts the ACR import logic to use an ACR-specific OAuth scope and additional parameters, and adds helper methods for subscription and resource group lookup. |
| src/aosm/HISTORY.rst | Adds a 2.0.0b4 changelog entry describing the fix for unauthorized errors when publishing to ACR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.