-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS}: fix and enrich prompt message #9548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes and enriches prompt messages in the AKS agent extension by dynamically generating CLI command flags to provide more accurate guidance to users. The changes ensure that error messages and help prompts display the correct command syntax with all required parameters.
Changes:
- Version bumped from 1.0.0b15 to 1.0.0b16
- Added
command_flags()andinit_command_flags()helper methods to bothAKSAgentManagerandAKSAgentManagerClientclasses to dynamically generate CLI flags - Updated all user-facing prompt messages to use these helper methods for consistent and accurate command suggestions
- Enhanced cluster mode cleanup to wait for pods to be removed after Helm uninstall
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-agent/setup.py | Version bump to 1.0.0b16 |
| src/aks-agent/azext_aks_agent/custom.py | Updated error/help messages to dynamically include correct CLI flags using new helper methods |
| src/aks-agent/azext_aks_agent/agent/k8s/aks_agent_manager.py | Added abstract method init_command_flags() and concrete implementations of both command_flags() and init_command_flags() in both manager classes; added _wait_for_pods_removed() method and integrated it into cleanup flow |
| src/aks-agent/azext_aks_agent/_help.py | Updated help text to include placeholder parameters in prerequisite command |
| src/aks-agent/HISTORY.rst | Added changelog entry for version 1.0.0b16 with description of fixes |
eeb64f6 to
f3b627e
Compare
|
[Release] Update index.json for extension [ aks-agent-1.0.0b16 ] : https://dev.azure.com/msazure/One/_build/results?buildId=150911090&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.