Skip to content

Conversation

@mainred
Copy link
Member

@mainred mainred commented Jan 25, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 25, 2026 14:36
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 25, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 25, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes and enriches prompt messages in the AKS agent extension by dynamically generating CLI command flags to provide more accurate guidance to users. The changes ensure that error messages and help prompts display the correct command syntax with all required parameters.

Changes:

  • Version bumped from 1.0.0b15 to 1.0.0b16
  • Added command_flags() and init_command_flags() helper methods to both AKSAgentManager and AKSAgentManagerClient classes to dynamically generate CLI flags
  • Updated all user-facing prompt messages to use these helper methods for consistent and accurate command suggestions
  • Enhanced cluster mode cleanup to wait for pods to be removed after Helm uninstall

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/aks-agent/setup.py Version bump to 1.0.0b16
src/aks-agent/azext_aks_agent/custom.py Updated error/help messages to dynamically include correct CLI flags using new helper methods
src/aks-agent/azext_aks_agent/agent/k8s/aks_agent_manager.py Added abstract method init_command_flags() and concrete implementations of both command_flags() and init_command_flags() in both manager classes; added _wait_for_pods_removed() method and integrated it into cleanup flow
src/aks-agent/azext_aks_agent/_help.py Updated help text to include placeholder parameters in prerequisite command
src/aks-agent/HISTORY.rst Added changelog entry for version 1.0.0b16 with description of fixes

@mainred mainred force-pushed the fix-prompt-message branch from eeb64f6 to f3b627e Compare January 27, 2026 13:03
@yanzhudd yanzhudd merged commit 23d9884 into Azure:main Jan 28, 2026
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-agent-1.0.0b16 ] : https://dev.azure.com/msazure/One/_build/results?buildId=150911090&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants