feat: capture aks-node-controller errors into Guest Agent Events #7773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devinwong
requested review from
AbelHu,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Guest Agent event logging to the aks-node-controller wrapper script to capture both successful completions and errors for monitoring and telemetry purposes.
Changes:
- Added
createGuestAgentEventfunction to generate Guest Agent events in JSON format - Events are now created for both successful completion and error cases
- Added test coverage for error scenario using ShellSpec
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| parts/linux/cloud-init/artifacts/aks-node-controller-wrapper.sh | Implements Guest Agent event creation with a new createGuestAgentEvent function and calls it for both success and failure cases |
| spec/parts/linux/cloud-init/artifacts/aks_node_controller_wrapper_spec.sh | Adds test case to verify Guest Agent event is created on non-zero exit with correct TaskName, EventLevel, and Message |
parts/linux/cloud-init/artifacts/aks-node-controller-wrapper.sh
Outdated
Show resolved
Hide resolved
spec/parts/linux/cloud-init/artifacts/aks_node_controller_wrapper_spec.sh
Show resolved
Hide resolved
parts/linux/cloud-init/artifacts/aks-node-controller-wrapper.sh
Outdated
Show resolved
Hide resolved
parts/linux/cloud-init/artifacts/aks-node-controller-wrapper.sh
Outdated
Show resolved
Hide resolved
spec/parts/linux/cloud-init/artifacts/aks_node_controller_wrapper_spec.sh
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
capture aks-node-controller errors into
Which issue(s) this PR fixes:
Fixes #